Red Hat Bugzilla – Bug 576615
RFE: add InstallPrinterDrivers D-Bus method for session service
Last modified: 2010-03-27 01:29:38 EDT
Created attachment 402350 [details]
Description of problem:
The attached patch brings kpackagekit into line with gnome-packagekit as far as automatic printer driver installation support goes.
It simply adds a D-Bus method, InstallPrinterDrivers.
I have tested it locally.
Version-Release number of selected component (if applicable):
I'm taking this.
The patch looks sane.
One note for efficiency: The one-character strings in PkInstallPrinterDrivers::start can probably all be characters, e.g. '_' instead of "_". QString::split, the second argument of QString::replace and QTextStream::operator<< all accept char or QChar.
We should also get this upstreamed.
Created attachment 402381 [details]
I have attached a version of the patch with characters instead of the 1-character strings. (Otherwise, it is identical to the original patch.) This is the version I'm going to apply and which should be sent upstream. (KDE's Krazy2 code checker is going to complain about the 1-character strings otherwise. ;-) )
Built for Rawhide, building for F-13, will queue for testing once built.
Thank you for the patch!
kdeutils-4.4.1-2.fc13,kpackagekit-0.6.0-0.9.20100301svn.fc13 has been submitted as an update for Fedora 13.
kdeutils-4.4.1-2.fc13, kpackagekit-0.6.0-0.9.20100301svn.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update kdeutils kpackagekit'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/kdeutils-4.4.1-2.fc13,kpackagekit-0.6.0-0.9.20100301svn.fc13
kdeutils-4.4.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
This one is actually resolved by kpackagekit-0.6.0-2.fc13 which also went out to stable today.