Spec URL: http://gtf.org/garzik/rng-tools/rng-tools.spec SRPM URL: http://gtf.org/garzik/rng-tools/rng-tools-2-1.fc11.src.rpm Description: Support utilities for hardware random number generators. NOTE: This is a rename of an existing package, rng-utils, to conform to Fedora package naming guidelines. The upstream package name is "rng-tools", and it is being renamed FROM "rng-utils" TO "rng-tools" to conform to upstream.
Oh, you made a new review. Assigning.
*** Bug 226375 has been marked as a duplicate of this bug. ***
$ rpmlint rng-tools-* rng-tools.src: W: invalid-url Source0: http://download.sourceforge.net/gkernel/rng-tools-2.tar.gz HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - Change Requires: /sbin/chkconfig /sbin/service to Requires: chkconfig initscripts to speed up dependency resolution. - Patch1 but no Patch0? - Must Obsoletes: rng-utils <= 1:2.0-4 . - Source URL should be http://downloads.sourceforge.net/gkernel/rng-tools-2.tar.gz not http://download.sourceforge.net/gkernel/rng-tools-2.tar.gz Ideally %{version} macro should be used here. - %configure picks up correct compiler flags. make CFLAGS="$RPM_OPT_FLAGS" should be make %{?_smp_mflags} to enable SMP compilation. - Macros are mixed. After correction of above (make) problem, there aren't any macro problems any more. - You can drop mkdir -p %{buildroot}%{_sbindir} mkdir -p %{buildroot}%{_initrddir} mkdir -p %{buildroot}%{_sysconfdir}/sysconfig mkdir -p %{buildroot}%{_mandir}/man{1,8} as this is (or at least should be!) automatically done by make install. - If you %define _sbindir /sbin at the top of the spec file, you can use plain %configure and %{_sbindir} in %files. - You might want to change the .gz suffixes of the man pages to .* in %files. - Add AUTHORS, ChangeLog, COPYING, NEWS and README to %doc.
Addressed these comments. Thanks for the review. Updated SPEC (same URL): http://gtf.org/garzik/rng-tools/rng-tools.spec Updated SRPM: http://gtf.org/garzik/rng-tools/rng-tools-2-2.fc11.src.rpm
- The sbindir define should actually be a global. - The buildroot tag is obsolete, use BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) instead. *** rpmlint output: rng-tools.x86_64: W: obsolete-not-provided rng-utils 3 packages and 0 specfiles checked; 0 errors, 1 warnings. This is OK. MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK The package has been APPROVED
How does one make the sbindir define global?
Just use %global instead of %define. https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
Thanks. Updated for your comments, here is the latest: Spec URL: http://gtf.org/garzik/rng-tools/rng-tools.spec SRPM URL: http://gtf.org/garzik/rng-tools/rng-tools-2-3.fc11.src.rpm
Still approved. Continue by applying for cvs branch, marking rng-utils as dead in cvs and requesting its removal from rawhide.
New Package CVS Request ======================= Package Name: rng-tools Short Description: Hardware random number generator utilities Owners: jgarzik Branches: F-11 F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Ping. - Mark rng-utils as dead in CVS and request its removal from rawhide. - Import the other branches, build the packages and file the updates to them.
Jeff: please finish this off.