Spec URL: http://kalev.fedorapeople.org/apiextractor.spec SRPM URL: http://kalev.fedorapeople.org/apiextractor-0.4.0-1.fc14.src.rpm Description: The API Extractor library is used by the binding generator to parse headers of a given library and merge this data with information provided by typesystem (XML) files, resulting in a representation of how the API should be exported to the chosen target language. The generation of source code for the bindings is performed by specific generators using the API Extractor library. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2076874
Hi Kalev, Would you be interested in packaging the whole pyside set? BTW, %{_libdir}/cmake/ApiExtractor-%{version}/ seems not the right place for cmake modules.
(In reply to comment #1) > Would you be interested in packaging the whole pyside set? Yes, that's my plan. Would you be interested in reviewing the whole set? > BTW, %{_libdir}/cmake/ApiExtractor-%{version}/ seems not the right place for > cmake modules. This is the place where cmake-aware projects put their arch-specific configuration [1] (the files may contain references to %{_libdir}, for example). The directory %{_libdir}/cmake/ is roughly similar to %{_libdir}/pkgconfig/ -- both are placed under %{_libdir} for the same reason. Several KDE packages install files in this directory and Fedora cmake package recently started owning the directory [2]. [1] http://www.cmake.org/Wiki/CMake_2.6_Notes#Packages [2] http://cvs.fedoraproject.org/viewvc/rpms/cmake/devel/cmake.spec?r1=1.76&r2=1.77
(In reply to comment #2) > (In reply to comment #1) > > Would you be interested in packaging the whole pyside set? > Yes, that's my plan. Would you be interested in reviewing the whole set? > > BTW, %{_libdir}/cmake/ApiExtractor-%{version}/ seems not the right place for > > cmake modules. > This is the place where cmake-aware projects put their arch-specific > configuration [1] (the files may contain references to %{_libdir}, for > example). The directory %{_libdir}/cmake/ is roughly similar to > %{_libdir}/pkgconfig/ -- both are placed under %{_libdir} for the same reason. > Several KDE packages install files in this directory and Fedora cmake package > recently started owning the directory [2]. > [1] http://www.cmake.org/Wiki/CMake_2.6_Notes#Packages > [2] > http://cvs.fedoraproject.org/viewvc/rpms/cmake/devel/cmake.spec?r1=1.76&r2=1.77 Thanks for clarification. currently fedora doesn't have a packaging guideline according to cmake modules(even a draft), so I'm a little confusion about this, historically cmake package didn't own {_libdir}/cmake and some packages store cmake modules on %{_datadir}/cmake/%{name} (e.g. boost 1.41).
(In reply to comment #3) > Thanks for clarification. currently fedora doesn't have a packaging guideline > according to cmake modules(even a draft), so I'm a little confusion about this, > historically cmake package didn't own {_libdir}/cmake and some packages store > cmake modules on %{_datadir}/cmake/%{name} (e.g. boost 1.41). Right, cmake searches in both %{_datadir}/cmake/ and %{_libdir}/cmake/ (and some more places), it's just that you can't put arch-specific configuration in %{_datadir}. Just for reference I looked up what packages install in these directories. Packages which install cmake modules in %{_datadir}/cmake/: shared-desktop-ontologies-devel boost-devel Packages which install cmake modules in %{_libdir}/cmake/: kdepimlibs-devel kdevplatform-devel kdebase-workspace-devel akonadi-devel
(In reply to comment #2) > (In reply to comment #1) > > Would you be interested in packaging the whole pyside set? > Yes, that's my plan. Would you be interested in reviewing the whole set? I'd like to review pyside set several weeks later after I finish package reviews that were assigned to me already.
Updated to 0.6.0. Spec URL: http://kalev.fedorapeople.org/apiextractor.spec SRPM URL: http://kalev.fedorapeople.org/apiextractor-0.6.0-1.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2252774
apiextractor.src: W: spelling-error %description -l en_US typesystem -> type system, type-system, typesetter apiextractor.x86_64: W: spelling-error %description -l en_US typesystem -> type system, type-system, typesetter apiextractor-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. MUST: rpmlint must be run on every package. The output should be posted in the review. Please update spec to include the spelling fixes. The no-documentation warning is something that should be addressed. Maybe ship the "doc" folder in the -devel subpackage as %doc ?
* Sun Jun 20 2010 Kalev Lember <kalev> - 0.6.0-2 - Build html documentation and ship it in -devel subpackage - typo fix in description Spec URL: http://kalev.fedorapeople.org/apiextractor.spec SRPM URL: http://kalev.fedorapeople.org/apiextractor-0.6.0-2.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2259495
apiextractor-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/apiextractor-devel-0.6.0/html/.buildinfo 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Please remove this directory.
* Sun Jun 20 2010 Kalev Lember <kalev> - 0.6.0-3 - Removed .buildinfo file from documentation directory Spec URL: http://kalev.fedorapeople.org/apiextractor.spec SRPM URL: http://kalev.fedorapeople.org/apiextractor-0.6.0-3.fc14.src.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings. Looks good. Passes all MUSTS and all SHOULDS.
Thank you for the review, Jonathan! New Package CVS Request ======================= Package Name: apiextractor Short Description: Library headers parser to extract API information Owners: kalev Branches: F-13 InitialCC:
Some suggestions: Group for apoextractor should be Group: System Environment/Libraries, Development/Libraries is for -devel only. Also, some rpm warnings can be ignored, e.g. spelling-error, it's Okay. I noticed apiextractor rpm for opensuse patched the place of cmake modules from %{_libdir}/cmake/ApiExtractor-%{version}/ to %{_libdir}/cmake/ApiExtractor, I' not sure if it's needed.
(In reply to comment #13) > Group for apoextractor should be Group: System Environment/Libraries, > Development/Libraries is for -devel only. I'll change that, thanks. By the way, do you know of any Fedora guidelines for choosing RPM groups? I guess there are none, since RPM groups are pretty much obsoleted by comps. > I noticed apiextractor rpm for opensuse patched the place of cmake modules from > %{_libdir}/cmake/ApiExtractor-%{version}/ to %{_libdir}/cmake/ApiExtractor, I' > not sure if it's needed. No idea why they would want to do that. CMake searches both directories for module configuration files, so there is really no advantage using one over other. Do you have a link to that opensuse package?
Updated owners list. New Package CVS Request ======================= Package Name: apiextractor Short Description: Library headers parser to extract API information Owners: kalev rdieter kkofler than ltinkl Branches: F-13 InitialCC:
(In reply to comment #14) > (In reply to comment #13) > > Group for apoextractor should be Group: System Environment/Libraries, > > Development/Libraries is for -devel only. > I'll change that, thanks. > By the way, do you know of any Fedora guidelines for choosing RPM groups? I > guess there are none, since RPM groups are pretty much obsoleted by comps. NO guideline as I known, but comps can not replace rpm group because most libraries are not registerd in comps. > > I noticed apiextractor rpm for opensuse patched the place of cmake modules from > > %{_libdir}/cmake/ApiExtractor-%{version}/ to %{_libdir}/cmake/ApiExtractor, I' > > not sure if it's needed. > No idea why they would want to do that. CMake searches both directories for > module configuration files, so there is really no advantage using one over > other. > Do you have a link to that opensuse package? No difference between the two places for cmake modules I think, but we still need a convention to treat cmake modules. See http://www.pyside.org/downloads/ http://download.opensuse.org/repositories/home:/cgoncalves:/pyside:/
CVS done (by process-cvs-requests.py).
apiextractor-0.6.0-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/apiextractor-0.6.0-4.fc13
apiextractor-0.6.0-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update apiextractor'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/apiextractor-0.6.0-4.fc13
apiextractor-0.6.0-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: apiextractor New Branches: el6 Owners: than
Git done (by process-git-requests).
Package Change Request ====================== Package Name: apiextractor New Branches: epel7 Owners: than jreznik ltinkl kkofler geertj rdieter