Bug 577432 - The --grow option for RAID partitions should not be allowed
Summary: The --grow option for RAID partitions should not be allowed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 14
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: anaconda_trace_hash:62d2c68dcc465f19a...
Depends On: 576870
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-03-27 00:41 UTC by Dave Cantrell
Modified: 2010-12-03 14:25 UTC (History)
7 users (show)

Fixed In Version:
Clone Of: 576870
Environment:
Last Closed: 2010-12-02 19:25:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 RHEL Program Management 2010-03-27 00:58:43 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 2 Chris Lumens 2010-03-29 19:40:12 UTC
Removing --grow support for some RAID levels makes it feel like what we're really doing here is adding a hack to work around a bug in anaconda.  If --grow isn't recommended, we should remove it for all.  If it works in some cases but not others, we should fix the bug.

Comment 3 Chris Lumens 2010-04-14 19:33:41 UTC
Dave - what do you think?  Should I deprecate --grow for all RAID commands or is there an actual bug here we should fix instead of working around?

Comment 4 David Lehman 2010-04-14 19:45:50 UTC
I would like to see grow disallowed for all raid partitions. Allowing it and ensuring that it will work means that the bowels of the partition allocation code need to know about stuff they have no business knowing so that we can guarantee two partitions end up being the same size. My take is that we should either allow it with the caveat that we make no guarantees that any two partitions will end up being the same size (the current situation), or we should disallow it completely for software raid partitions. If we choose the latter, do we need to also do something in the GUI?

Comment 5 Bug Zapper 2010-07-30 11:12:31 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle.
Changing version to '14'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Chris Lumens 2010-08-11 15:27:37 UTC
Turns out this needs to be handled in anaconda, not in pykickstart.  pykickstart doesn't know anything about "raid.XX" as a mount point for the partition command, and I would prefer to not add that knowledge.

Comment 7 Fedora Update System 2010-08-12 18:38:29 UTC
anaconda-14.16-1.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/anaconda-14.16-1.fc14

Comment 8 Jan ONDREJ 2010-11-12 14:04:35 UTC
Looks like something is wrong with this check. I am trying to create one 4 GB partition and LVM should use other space. But this fails on fedora 14 (works on fedora 13):

part raid.11 --size=1024 --grow --ondisk=vda

How I can define to use 4 GB mirror for / and to use free space for LVM PV?

Comment 9 David Lehman 2010-11-12 15:52:44 UTC
(In reply to comment #8)

There is no reason to use --grow for your raid partition if you already know the size you want it to be. If you want a 4GB partition you do this:

  part raid.11 --size=4096 --ondisk=vda

Then your pv would be defined as follows:

  part pv.1 --size=500 --grow --ondisk=vda

Comment 10 Jan ONDREJ 2010-11-12 19:45:14 UTC
(In reply to comment #9)
> There is no reason to use --grow for your raid partition if you already know
> the size you want it to be. If you want a 4GB partition you do this:

I know only size of partition 1, I need to use whole disk, so partition 2 should be at maximum size.

>   part raid.11 --size=4096 --ondisk=vda

Well, this is for root partition, 1st partition.

> Then your pv would be defined as follows:
> 
>   part pv.1 --size=500 --grow --ondisk=vda

I can't use this. I need mirror on both root and PV, so I need to configure raid before PV. This is my default setup (works with F13):

clearpart --all --initlabel
part raid.01 --size=4096 --ondisk=vda
part raid.02 --size=4096 --ondisk=vdb
raid / --level=1 --device=md0 --fstype=ext3 raid.01 raid.02
part raid.11 --size=1 --grow --ondisk=vda
part raid.12 --size=1 --grow --ondisk=vdb
raid pv.01 --level=1 --device=md1 raid.11 raid.12
volgroup vg1 pv.01
logvol swap --vgname=vg1 --size=1024 --name=swap --fstype=ext3

Also I can't use logvol --size, because I need to use 90% of my VG and leave some free space for snapshots. Because I don't know, how large is my disks, I can't define exact values. Can I somehow compute them from /sys/block disk parameters?

On this page:
  http://docs.fedoraproject.org/en-US/Fedora/14/html/Installation_Guide/s1-kickstart2-options.html
there is nothing about --size parameter for raid command. Also paritioning examples and advanced partitioning examples are wrong. They use this now useless part --grow parameters.

Do you need another bug for part --grow option problems?

Comment 11 Ian Ward Comfort 2010-11-13 03:57:41 UTC
I also use a default partitioning scheme much like the "Advanced Partitioning Example" from the Fedora Installation Guide, which is no longer allowed.  The --grow option is very useful in my environment, where my systems all have different disk sizes, but every system has two or more identical drives in it.  (I want to give each system a software-RAID mirror, and a /boot partition and maximally-sized PV on top of that.)

Is there any chance that this change could be reverted, in favor of documenting the limitations of --grow as suggested in comment 4?  It will be rather painful to work around this regression in functionality here.

Comment 12 Chris Lumens 2010-11-15 17:04:43 UTC
> http://docs.fedoraproject.org/en-US/Fedora/14/html/Installation_Guide/s1-kickstart2-options.html
> there is nothing about --size parameter for raid command. Also paritioning
> examples and advanced partitioning examples are wrong. They use this now
> useless part --grow parameters.

I have updated the documentation on the Kickstart wiki page to no longer refer to this option.  It'll get picked up in the next release when they update the installation guide.  Or, you could open a bug against the documentation for them to change it now.

Comment 13 Jan ONDREJ 2010-11-15 19:22:39 UTC
(In reply to comment #12)
> I have updated the documentation on the Kickstart wiki page to no longer refer
> to this option.  It'll get picked up in the next release when they update the
> installation guide.  Or, you could open a bug against the documentation for
> them to change it now.

This is not a real solution for users like me. I still don't know, how to create an LVM PV on md1 RAID on whole disk.

If you use mdadm metadata version 1.1, there is no need to create same size partitions, metadata are at start of partition and even if not all space will be used, partitions will still be usable.

I still don't know, why this options has been disabled. Worked well in Fedora<=13.

Do you need another bug report for revert of this patch? May be there will be more users, which need this functionality.

Comment 14 Joachim Schröder 2010-11-25 20:58:28 UTC
(In reply to comment #13)
> This is not a real solution for users like me. I still don't know, how to
> create an LVM PV on md1 RAID on whole disk.
> 
> If you use mdadm metadata version 1.1, there is no need to create same size
> partitions, metadata are at start of partition and even if not all space will
> be used, partitions will still be usable.
> 
> I still don't know, why this options has been disabled. Worked well in
> Fedora<=13.
> 
> Do you need another bug report for revert of this patch? May be there will be
> more users, which need this functionality.

I agree with Jan, if --grow failed partly on RAID partitions, then --grow should either be limited to working constellations like RAID1 or the bug behind should be fixed.

If we allow for creation of mirrored partitions in kickstart, --grow is a must, IMHO.

Comment 15 Chris Lumens 2010-12-02 19:25:04 UTC
This bug report was for tracking the fact that since growing RAID partitions in anaconda doesn't work anymore, we should not support it in kickstart.  If you would like to discuss making grow work, we should do it in a separate bug report or on anaconda-devel-list.  Simply reverting this patch doesn't do anything about the underlying problem.  Thanks.

Comment 16 Jan ONDREJ 2010-12-03 14:25:34 UTC
OK, new bug filled. BZ# 659700.


Note You need to log in before you can comment on or make changes to this bug.