SPEC: http://pbrobinson.fedorapeople.org/python-geoclue.spec SRPM: http://pbrobinson.fedorapeople.org/python-geoclue-0.1.0-1.fc12.src.rpm Description: This Python module uses the Geoclue D-Bus API to implement a nice API for python developers and facilitate their life. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2082418
Review: Good: - rpmlint $ rpmlint ./python-geoclue-0.1.0-1.fc13.src.rpm noarch/python-geoclue-0.1.0-1.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - group ok - name ok (I believe you should directly provide python2-geoclue, because this is likly to happen in the future.) - BuildRoot ok If you don't want to build in RHEL, could you delete that? - %prep ok - %build ok - %install ok - no libs - no *.la - buildarch: noarch ok Needswork: - %files * you should change 0.1.0 to %{version}, this way you don't need to change this all the time. * how about %doc docs/* ? - license wrong: GPLv3 -> GPLv3+ - BR wrong: * What is pygobject2-devel for? Please BR pygobjec2 instead (only the python files are needed, not the whole -devel package). * Instead you need to also Require pygobject2 for python importing on runtime ############################################ All needswork are easyfixes, ping me if you object to something. ############################################ APPROVED
Thanks! > Needswork: > - %files > * you should change 0.1.0 to %{version}, this way you don't need to change > this all the time. > * how about %doc docs/* ? > > - license wrong: GPLv3 -> GPLv3+ > > - BR wrong: > * What is pygobject2-devel for? > Please BR pygobjec2 instead (only the python files are needed, not the > whole -devel package). > * Instead you need to also Require pygobject2 for python importing on runtime I believe these are all fixed now.
New Package CVS Request ======================= Package Name: python-geoclue Short Description: A Geoclue python module Owners: pbrobinson Branches: F-13 F-12 F-11 InitialCC:
CVS done (by process-cvs-requests.py).
python-geoclue-0.1.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc12
python-geoclue-0.1.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc11
python-geoclue-0.1.0-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-geoclue-0.1.0-1.fc13
In rawhide
(In reply to comment #2) > I believe these are all fixed now. Yepp, thanks.
python-geoclue-0.1.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
python-geoclue-0.1.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
python-geoclue-0.1.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.