Spec URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy.spec SRPM URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy-0.0.4.22-1.fc12.src.rpm Description: Daisy is a versatile yet simple plasma application launcher applet. It supports three different types of roles: a circular dock, a media controller and a linear dock.
Just a suggestion Julian: You can use %{_kde4_appsdir}/desktoptheme/default/widgets/*.svgz instead of %{_kde4_datadir}/kde4/apps/desktoptheme/default/widgets/*svgz (In my system %{_kde4_appsdir} expands into /usr/share/kde4/apps). This is a nice plasmoid! I've build the RPM of this program for my personal use. Cheers, Germán.
I didn't think about the %{_kde4_appsdir} macro, thanks for the suggestion Germán! Spec URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy.spec SRPM URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy-0.0.4.22-2.fc12.src.rpm
Daisy 0.0.4.23 released. URL and Source0 should be updated. URL: http://www.cdlszm.org/ Source0: http://cdlszm.org/downloads/plasma-applet-daisy-%{version}.tar.gz BuildRoot tag is not needed any more: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Woops, totally forgot this review :) Well anyway, here are: Spec URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy.spec SRPM URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy-0.0.4.23-1.fc13.src.rpm
Ok. Will wait for Fedora-legal response. http://lists.fedoraproject.org/pipermail/legal/2010-July/001312.html
I think it should be OK though, as daisy doesn't support the zoom effect on mouseover which was the problem IIRC. Well, let's wait and see.
(In reply to comment #6) > I think it should be OK though, as daisy doesn't support the zoom effect on > mouseover which was the problem IIRC. > > Well, let's wait and see. Is simple mouseover effect not similar to zoom effect? http://img227.imageshack.us/img227/5585/snapshot1pc.png
(In reply to comment #7) > (In reply to comment #6) > > I think it should be OK though, as daisy doesn't support the zoom effect on > > mouseover which was the problem IIRC. > > > > Well, let's wait and see. > > Is simple mouseover effect not similar to zoom effect? > http://img227.imageshack.us/img227/5585/snapshot1pc.png I think the OS X dock zooms in many icons at once (like http://blog.buerstinghaus.net/images/nexus_dock_zoom.png ), but FE-Legal probably knows better.
This comes close, but is okay, as the other icons are not affected when the mouseover icon zooms in/out.
(In reply to comment #9) > This comes close, but is okay, as the other icons are not affected when the > mouseover icon zooms in/out. Thanks. $ rpmlint kde-plasma-daisy-0.0.4.23-1.fc14.i686.rpm kde-plasma-daisy-0.0.4.23-1.fc14.x86_64.rpm kde-plasma-daisy-debuginfo-0.0.4.23-1.fc14.i686.rpm kde-plasma-daisy-debuginfo-0.0.4.23-1.fc14.x86_64.rpm kde-plasma-daisy-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/plasma-applet-daisy-0.0.4.23/applet/src/daisyTasks.cpp kde-plasma-daisy-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/plasma-applet-daisy-0.0.4.23/applet/src/daisyTasks.cpp 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Fix of daisyTasks.cpp permissions needed. Please, update spec file. There is old spec on your link.
The spec file is for version 0.0.4.23-1. Maybe your browser cache is still having the old file?
(In reply to comment #11) > The spec file is for version 0.0.4.23-1. Maybe your browser cache is still > having the old file? You are right. Sorry for this.
(In reply to comment #12) > (In reply to comment #11) > > The spec file is for version 0.0.4.23-1. Maybe your browser cache is still > > having the old file? > > You are right. Sorry for this. Absolutely no problem :) Here are the new Spec and SRPM: Spec URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy.spec SRPM URL: http://julian.fedorapeople.org/kde-plasma-daisy/kde-plasma-daisy-0.0.4.23-2.fc13.src.rpm
Package Review ============== MUST Items: + rpmlint output OK $ rpmlint kde-plasma-daisy-0.0.4.23-2.fc14.src.rpm kde-plasma-daisy-0.0.4.23-2.fc14.i686.rpm kde-plasma-daisy-0.0.4.23-2.fc14.x86_64.rpm kde-plasma-daisy-debuginfo-0.0.4.23-2.fc14.i686.rpm kde-plasma-daisy-debuginfo-0.0.4.23-2.fc14.x86_64.rpm kde-plasma-daisy.src: W: no-buildroot-tag 5 packages and 0 specfiles checked; 0 errors, 1 warnings. + named and versioned according to the Package Naming Guidelines. Package name match the upstream project name (Daisy Plasma) kde- prefix used by convention for all plasma applets + spec file name matches base package name + complies with all the legal guidelines: + License: GPLv3+ valid, matches actual license + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING packaged as %doc + source matches upstream: MD5: b195b1fdec03c5202ba7247160603e19 plasma-applet-daisy-0.0.4.23.tar.gz SHA1: fd4fc608106f03976555777a44e36c84b7397408 plasma-applet-daisy-0.0.4.23.tar.gz SHA256: a3f28e069ec92abf329c86bd71b75ba0fc8475e2554b9e0c94fb2ac993073528 plasma-applet-daisy-0.0.4.23.tar.gz + builds on at least one arch F14 Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2298993 + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) + locales are handled properly by using %find_lang macro + ldconfig call not needed (no shared libraries in dynamic linker's default paths) + no duplicated system libraries + package not relocatable (no Prefix tag) + directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories) + no duplicate files in %files + permissions correct, %defattr(-,root,root,-) used correctly, executables have executable permissions + macros used where possible + no non-code content + no large documentation files, so no -doc package needed + no %doc files required at runtime + no header files which would need to be in a -devel subpackage + no static libraries, so no -static package needed + no devel symlinks which would need to be in a -devel subpackage + devel packages must require the base package (no -devel package) + no .la files + no .desktop file needed in /usr/share/applications for plasma applets + desktop-file-validate call not needed for .desktop files in /usr/share/kde4/services + all filenames are valid UTF-8 + other packaging guidelines: + complies with the FHS + proper changelog, tags, BuildRequires, Summary, Description + no macros in Summary and Description + no non-UTF-8 characters + all relevant documentation included as %doc + RPM_OPT_FLAGS are used in %{cmake_kde4} macro + debuginfo package is valid (contains stripped symbols from ELF binaries and source code related to them) + no rpaths + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + timestamps are preserved + _smp_mflags used + not a web application, so web application guideline doesn't apply + no conflicts SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (F14 Koji scratch build) + successfully tested the package functionality (no segfaults noticed) + scriptlets are sane (no scriptlets used) + subpackages other than devel should require the base package using a fully versioned dependency (no subpackages) + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies + no binaries/scripts that needs man pages Package is APPROVED.
(In reply to comment #14) > Package is APPROVED. Thanks for the review! :)
New Package CVS Request ======================= Package Name: kde-plasma-daisy Short Description: A versatile application launcher Owners: julian Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
kde-plasma-daisy-0.0.4.23-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kde-plasma-daisy-0.0.4.23-2.fc13
kde-plasma-daisy-0.0.4.23-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-daisy-0.0.4.23-2.fc12
kde-plasma-daisy-0.0.4.23-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-plasma-daisy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/kde-plasma-daisy-0.0.4.23-2.fc13
kde-plasma-daisy-0.0.4.23-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update kde-plasma-daisy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/kde-plasma-daisy-0.0.4.23-2.fc12
kde-plasma-daisy-0.0.4.23-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
kde-plasma-daisy-0.0.4.23-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.