SPEC: http://rakesh.fedorapeople.org/spec/django-moko.spec SRPM: http://rakesh.fedorapeople.org/srpm/django-mako-0.1.3-1.fc12.src.rpm Description: Replacement for default template system provided by Django.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2088619
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2088635 - rpmlint is silent for SRPM and for RPM. django-mako.src: E: invalid-spec-name Your spec filename must end with '.spec'. If it's not the case, rename your file and rebuild your package. + source files match upstream url (sha1sum) 23caac692fdf7fec6edb0fb46ccf464fa4043df0 django-mako-0.1.3.tar.gz Suggestions: 1) Change spec file name to correct upstream project name django-mako.spec 2) Please go through updated packaging guidelines https://fedoraproject.org/wiki/Packaging/Python Resubmit new SPEC and SRPM according to updated python packaging guidelines.
rpmlint is out of mind, or is it me? spec file name is correct.
oops sorry forgot to edit my review template I mean - rpmlint is NOT silent for SRPM django-mako.src: E: invalid-spec-name Your spec filename must end with '.spec'. If it's not the case, rename your file and rebuild your package. See https://bugzilla.redhat.com/show_bug.cgi?id=578759#c0, SPEC file included in SRPM is django-moko.spec which should be django-mako.spec
Ping? If not responded next 15 days will move this ticket to NEW queue.
http://rakesh.fedorapeople.org/spec/django-mako.spec http://rakesh.fedorapeople.org/srpm/django-mako-0.1.4-0.1.pre.fc13.src.rpm
The definition of a buildroot and cleaning of it in install section are superfluous but it is a not a blocker if you decide to retain them. Other than that, it looks good APPROVED
New Package CVS Request ======================= Package Name: django-mako Short Description: Mako Templates Plugin for Django Owners: rakesh Branches: F-12 F-13 EL-6 InitialCC
CVS done (by process-cvs-requests.py).
django-mako-0.1.4-0.1.pre.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc13
django-mako-0.1.4-0.1.pre.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc12
django-mako-0.1.4-0.1.pre.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-mako'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc13
django-mako-0.1.4-0.1.pre.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update django-mako'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc12
django-mako-0.1.4-0.1.pre.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
django-mako-0.1.4-0.1.pre.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.