Bug 578759 - Review request: django-mako - Mako Templates Plugin for Django
Summary: Review request: django-mako - Mako Templates Plugin for Django
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-01 09:46 UTC by Rakesh Pandit
Modified: 2010-06-08 19:42 UTC (History)
5 users (show)

Fixed In Version: django-mako-0.1.4-0.1.pre.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-06-08 19:33:10 UTC
Type: ---
Embargoed:
metherid: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Rakesh Pandit 2010-04-01 09:46:50 UTC
SPEC: http://rakesh.fedorapeople.org/spec/django-moko.spec
SRPM: http://rakesh.fedorapeople.org/srpm/django-mako-0.1.3-1.fc12.src.rpm

Description:
Replacement for default template system provided by Django.

Comment 2 Parag AN(पराग) 2010-04-01 10:14:04 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2088635
- rpmlint is silent for SRPM and for RPM.
django-mako.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.
+ source files match upstream url (sha1sum)
23caac692fdf7fec6edb0fb46ccf464fa4043df0  django-mako-0.1.3.tar.gz


Suggestions:
1) Change spec file name to correct upstream project name django-mako.spec
2) Please go through updated packaging guidelines
https://fedoraproject.org/wiki/Packaging/Python


Resubmit new SPEC and SRPM according to updated python packaging guidelines.

Comment 3 Rakesh Pandit 2010-04-01 11:30:35 UTC
rpmlint is out of mind, or is it me?

spec file name is correct.

Comment 4 Parag AN(पराग) 2010-04-01 12:16:19 UTC
oops sorry forgot to edit my review template I mean

- rpmlint is NOT silent for SRPM
django-mako.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.

See https://bugzilla.redhat.com/show_bug.cgi?id=578759#c0, SPEC file included in SRPM is django-moko.spec which should be django-mako.spec

Comment 5 Parag AN(पराग) 2010-04-26 04:30:34 UTC
Ping?
If not responded next 15 days will move this ticket to NEW queue.

Comment 7 Rahul Sundaram 2010-05-29 08:57:52 UTC
The definition of a buildroot and cleaning of it in install section are superfluous but it is a not a blocker if you decide to retain them.  Other than that, it looks good


APPROVED

Comment 8 Rakesh Pandit 2010-05-29 09:40:36 UTC
New Package CVS Request
=======================
Package Name: django-mako
Short Description: Mako Templates Plugin for Django
Owners: rakesh
Branches: F-12 F-13 EL-6
InitialCC

Comment 9 Kevin Fenzi 2010-05-31 19:18:05 UTC
CVS done (by process-cvs-requests.py).

Comment 10 Fedora Update System 2010-06-01 04:59:03 UTC
django-mako-0.1.4-0.1.pre.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc13

Comment 11 Fedora Update System 2010-06-01 05:08:07 UTC
django-mako-0.1.4-0.1.pre.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc12

Comment 12 Fedora Update System 2010-06-01 18:27:30 UTC
django-mako-0.1.4-0.1.pre.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update django-mako'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc13

Comment 13 Fedora Update System 2010-06-01 18:27:44 UTC
django-mako-0.1.4-0.1.pre.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update django-mako'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/django-mako-0.1.4-0.1.pre.fc12

Comment 14 Fedora Update System 2010-06-08 19:33:05 UTC
django-mako-0.1.4-0.1.pre.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-06-08 19:42:04 UTC
django-mako-0.1.4-0.1.pre.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.