Description of problem: When there is no enough space for guestfish to alloc a image file, guestfish doesn't report error. Version-Release number of selected component (if applicable): libguestfs-1.0.85-1.fc12.3.x86_64 guestfish-1.0.85-1.fc12.3.x86_64 How reproducible: 100% Steps to Reproduce: $ df -h . Filesystem Size Used Avail Use% Mounted on /dev/sda10 4.9G 4.6G 0 100% /home $ guestfish <<_EOF_ > alloc foo.img 10G > _EOF_ $ echo $? 0 $ ll foo.img -rw-rw-r-- 1 root root 0 2010-04-06 15:43 foo.img Actual results: No error report for the no enough space error, and return code is 0 which stand for no error happen in guestfish. Expected results: guestfish should report error and return code should be non-zero in such situation. Additional info:
This is a proper bug. posix_fallocate uses a non-standard way to return errors. Way to go POSIX committee. [...] RETURN VALUE posix_fallocate() returns zero on success, or an error number on fail- ure. Note that errno is not set.
Patch posted upstream: https://www.redhat.com/archives/libguestfs/2010-April/msg00028.html
Fix pushed upstream: http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=2ade61d1f864c75ce65c358e4ac8a012a897b89a
Fixed in 1.3.1.
libguestfs-1.2.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libguestfs-1.2.1-1.fc13
libguestfs-1.2.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libguestfs'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libguestfs-1.2.1-1.fc13
libguestfs-1.2.2-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libguestfs-1.2.2-1.fc13
Change product to upstream (Virtualization Tools).
libguestfs-1.2.2-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
tested with libguestfs-1.2.2-1.fc13 on Fedora 13: $ guestfish <<_EOF_ > alloc foo.img 10G > _EOF_ fallocate: No space left on device $ echo $? 1 change to VERIFIED.