Created attachment 405069 [details] Booting netboot.iso with proxy passed to kernel Description of problem: loader crashes when passing proxy to the kernel Version-Release number of selected component (if applicable): 13.37.2 How reproducible: Steps to Reproduce: 1. Boot install media, hit tab at grub menu 2. Add proxy=http://proxy.home:3128 to the kernel line 3. Hit enter and attempt to install Actual results: loader throws a SIGSEGV Expected results: Continue with stage2 Additional info: Tested on Beta RC5 netboot.iso and disc1.iso
0x40b90e - /usr/src/debug/anaconda-13.37.2/loader/loader.c:2317
Could it be as simple as: diff --git a/loader/loader.c b/loader/loader.c index a9514d1..b96923b 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -2332,14 +2332,14 @@ int main(int argc, char ** argv) { *argptr++ = strdup(loaderData.proxy); - if (strcmp(loaderData.proxyUser, "")) { + if (loaderData.proxyUser && strcmp(loaderData.proxyUser, "")) { int fd, ret; fd = open("/tmp/proxy", O_CREAT|O_TRUNC|O_RDWR, 0600); ret = write(fd, loaderData.proxyUser, strlen(loaderData.proxyUser)); ret = write(fd, "\r\n", 2); - if (loaderData.proxyPassword) { + if (loaderData.proxyPassword && strcmp(loaderData.proxyPassword, "")) { ret = write(fd, loaderData.proxyPassword, strlen(loaderData.proxyPassword)); ret = write(fd, "\r\n", 2); }
This patches fixes the problem. And reveals bug 580756
Brian confirms the fix, so let's just close this. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers
While trying to install F13 RC3 through a http proxy, kickstart file is still not retreived. Not causing SIGSEGV anymore, btw. Best Regards Marcus
(In reply to comment #5) > While trying to install F13 RC3 through a http proxy, kickstart file is still > not retreived. > > Not causing SIGSEGV anymore, btw. Can we file a new bug for this please? Sounds like the reported SIGSEGV is no longer occurring.
Bug: 592985 opened