Bug 580296 - "rtcwake" does miss the "off" option
Summary: "rtcwake" does miss the "off" option
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: util-linux-ng
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Karel Zak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-07 21:47 UTC by Piergiorgio Sartor
Modified: 2011-06-27 15:28 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-06-27 15:28:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Piergiorgio Sartor 2010-04-07 21:47:01 UTC
Description of problem:
The new option "off" of rtcwake does not work.

Version-Release number of selected component (if applicable):
util-linux-ng-2.17.2-1.fc13.x86_64.rpm

How reproducible:
Always.

Steps to Reproduce:
1.
Type (with any timeout):
rtcwake -s 90 -m off

Actual results:
Printout is:

rtcwake: wakeup from "off" using /dev/rtc0 at ...

but nothing happens.

Expected results:
The PC should shutdown and, possibly, restart in about 90 sec (or whatever was the time).

Additional info:

Well, it seems, looking at the source code, that the issue is around line 473:

...
	if (strcmp(suspend, "no") == 0)
		exit(EXIT_SUCCESS);
	else if (strcmp(suspend, "on") != 0) { <--- HERE SOMETHING FISHY
		sync();
		suspend_system(suspend);
	} else if (strcmp(suspend, "off") == 0) {
...

Adding a "printf(...);" before the "sync();" shows that this branch is selected instead of the next one, even if "suspend" == "off".

Of course, using "off" as power state doesn't produce any result, luckily :-)

I guess the two "if" should be swapped, not sure about the last "else" block.

Hope this helps,

bye,

pg

Comment 1 Fedora Update System 2010-04-08 08:17:05 UTC
util-linux-ng-2.17.2-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/util-linux-ng-2.17.2-2.fc13

Comment 2 Karel Zak 2010-04-08 08:24:31 UTC
I have also added --dry-run option to the upstream version, so we have a better way to test the basic rtcwake logic.

Piergiorgio, thanks for the report!

Comment 3 Piergiorgio Sartor 2010-04-08 18:20:36 UTC
Hi,

thanks for the really really quick fix!

I tested "rtcwake" of F13 from koji and the "off" option works fine, now.

Maybe the issue could be closed.

I also had a look at your patch. I think you made the right decision in having the "real" suspend as default condition after the "if else if" chain.

The "--dry-run" is also good to have, even if I hope it will not needed... ;-)

Thanks again,

bye,

pg

Comment 4 Fedora Update System 2010-04-09 03:49:49 UTC
util-linux-ng-2.17.2-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update util-linux-ng'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/util-linux-ng-2.17.2-2.fc13

Comment 5 Bug Zapper 2011-06-02 15:35:31 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Bug Zapper 2011-06-27 15:28:04 UTC
Fedora 13 changed to end-of-life (EOL) status on 2011-06-25. Fedora 13 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.