Created attachment 406199 [details]
temporary patch which fixes the bug

Description of problem:

If a given tablespace in Satellite with embedded Oracle db has 100 or more dbf files, then any attempt to extend with "db-control extend <tbsname>" fails.


Version-Release number of selected component (if applicable):

spacewalk-dobby-0.5.23-28.el5sat


How reproducible:

always


Steps to Reproduce:

1. create 100 oracle db files, by running e.g. something similar:

  $ for x in $(seq $(($(ls /rhnsat/data/rhnsat/data_* | sed -e "s/^.*_\(.*\).dbf$/\1/" | sort -n | tail -n 1) + 1)) 100); do db-control extend DATA_TBS; done

  It will count a number of the last db file+1 and then create db files counting to 100

2. run db-control again to hit the bug:

  $ db-control extend DATA_TBS


Actual results:

$ db-control extend DATA_TBS
Extending DATA_TBS... DBD::Oracle::db do failed: ORA-01537: cannot add file '/rhnsat/data/rhnsat/data_100.dbf' - file already part of database (DBD ERROR: OCIStmtExecute) [for Statement "ALTER TABLESPACE DATA_TBS ADD DATAFILE '/rhnsat/data/rhnsat/data_100.dbf' SIZE 512000 K REUSE"] at /usr/lib/perl5/vendor_perl/5.8.8/Dobby/DB.pm line 160.
$


Expected results:

$ db-control extend DATA_TBS
Extending DATA_TBS... done.
$


Additional info:

The problem is caused by the fact that an array holding paths to db files is not correctly sorted as it is an array of hashes not array of paths, so pop() function won't pickup the number 100, but 99 and therefore it fails to create already existing db file number 100.

---------------------------------------------------------------

Debugging /usr/lib/perl5/vendor_perl/5.8.8/Dobby/CLI/MaintCommands.pm shows that the @files array is not sorted numerically by filename for integers greater than 99. For example, the first 12 values of the array look like this ...

HASH(0x13295a10)  

/rhnsat/data/rhnsat/data_01.dbf  

HASH(0x13295a30)  

/rhnsat/data/rhnsat/data_02.dbf  

HASH(0x13295a40)  

/rhnsat/data/rhnsat/data_03.dbf  

HASH(0x13295a50)  

/rhnsat/data/rhnsat/data_04.dbf  

HASH(0x13295ab0)  

/rhnsat/data/rhnsat/data_05.dbf  

HASH(0x13295b10)  

/rhnsat/data/rhnsat/data_06.dbf  

HASH(0x13295b70)  

/rhnsat/data/rhnsat/data_07.dbf  

HASH(0x13295bd0)  

/rhnsat/data/rhnsat/data_08.dbf  

HASH(0x13295c30)  

/rhnsat/data/rhnsat/data_09.dbf  

HASH(0x13295c90)  

/rhnsat/data/rhnsat/data_10.dbf  

HASH(0x13295cf0)  

/rhnsat/data/rhnsat/data_100.dbf  

HASH(0x13295d50)  

/rhnsat/data/rhnsat/data_11.dbf  

HASH(0x13295db0)  

The problem comes on line 57 of MaintCommands.pm where the last value of the array is pop'ed which evaluates to 99 instead of 100.

---------------------------------------------------------------

The attached patch solves the issue.