Bug 583186 - Review Request: python3-chardet - Character encoding auto-detection in Python
Summary: Review Request: python3-chardet - Character encoding auto-detection in Python
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dave Malcolm
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: Python3F13
TreeView+ depends on / blocked
Reported: 2010-04-16 23:27 UTC by Thomas Spura
Modified: 2010-04-25 13:49 UTC (History)
4 users (show)

Fixed In Version: python3-chardet-2.0.1-2.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-04-25 13:49:59 UTC
Type: ---
dmalcolm: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Thomas Spura 2010-04-16 23:27:28 UTC
Spec URL: http://tomspur.fedorapeople.org/review/python3-chardet.spec
SRPM URL: http://tomspur.fedorapeople.org/review/python3-chardet-2.0.1-1.fc13.src.rpm
Character encoding auto-detection in Python. As
smart as your browser. Open source.

Upstream releases 2 different tarballs for python2 and python3.
See: http://chardet.feedparser.org/download/
This is the python3 package.

Please verify, that the license is LGPLv2+. python2-chardet claims to only be LGPLv2 (without the +). I think that's wrong.

$ rpmlint python3-chardet-2.0.1-1.fc13.src.rpm noarch/python3-chardet-2.0.1-1.fc13.noarch.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Thomas Spura 2010-04-16 23:29:02 UTC
CCing python2-chardet maintainer

Comment 2 Dave Malcolm 2010-04-22 16:28:18 UTC
OK: rpmlint must be run on every package. The output should be posted in the review.[1] 
rpmlint output (on a local build) is clean:
[david@f13 coding]$ rpmlint ~/rpmbuild/RPMS/noarch/python3-chardet-2.0.1-1.fc13.noarch.rpm python3-chardet-2.0.1-1.fc13.src.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. [3]
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4]
OK: The spec file must be written in American English. [5]
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
[david@surprise review]$ wget http://chardet.feedparser.org/download/python3-chardet-2.0.1.tgz
[david@surprise review]$ md5sum python3-chardet-2.0.1.tgz python3-chardet-2.0.1-1.fc13.src/python3-chardet-2.0.1.tgz 
ce4314913675a504aeda6a95fefdf482  python3-chardet-2.0.1.tgz
ce4314913675a504aeda6a95fefdf482  python3-chardet-2.0.1-1.fc13.src/python3-chardet-2.0.1.tgz

OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [7]
OK: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [8]
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
N/A: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
N/A: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10]
N/A: Packages must NOT bundle copies of system libraries.[11]
N/A: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [12]
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13]
OK: A Fedora package must not list a file more than once in the spec file's %files listings. [14]
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [15]
OK: Each package must consistently use macros. [16]
OK: The package must contain code, or permissable content. [17]
OK: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [18]
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [18]
N/A: Header files must be in a -devel package. [19]
N/A: Static libraries must be in a -static package. [20]
N/A: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [19]
N/A: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [21]
N/A: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.[20]
N/A: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [22]
OK: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [23]
OK: All filenames in rpm packages must be valid UTF-8. [24]

Note in particular that all of the paths in the build package payload are either below "/usr/lib/python3.1/site-packages" or "/usr/share/doc/python3-chardet-2.0.1", and so this ought to be entirely parallel-installable with the Python 2 python-chardet RPM.


Please can you add this package to the bulleted list at https://fedoraproject.org/wiki/Features/Python3F13#Completed_items
and to the table at https://fedoraproject.org/wiki/Features/Python3F13#Python_3_already_in_Fedora
after you import and build it  (have a look at what I've done for the other too-late for F13 Beta rpms e.g. python3-postgresql)


Comment 3 Thomas Spura 2010-04-22 17:27:54 UTC
Thanks for the review.

New Package CVS Request
Package Name: python3-chardet
Short Description: Character encoding auto-detection in Python
Owners: tomspur
Branches: F-13

Comment 4 Kevin Fenzi 2010-04-24 00:40:24 UTC
CVS done (by process-cvs-requests.py).

Comment 5 Fedora Update System 2010-04-24 18:08:39 UTC
python3-chardet-2.0.1-2.fc13 has been submitted as an update for Fedora 13.

Comment 6 Thomas Spura 2010-04-24 18:57:52 UTC
Just a FYI:

I removed the BR to python3-setuptools, because I blindly added this, because this was in the python-chardet.spec...
After verifying in a local mock build, this is not needed, because python3-chardet is building the egg with distuils.

-> Sucessfully imported in CVS without the python3-setuptools

Comment 7 Fedora Update System 2010-04-25 13:49:51 UTC
python3-chardet-2.0.1-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.