whereami is a tiny console application. Whereami displays information about the machine(location) you are working on. The information includes host name, IP address, present working directory etc. This is extremely useful for those, who tend to work remotely on several machines at the same time. SPEC: http://pjp.dgplug.org/tools/whereami.spec SORC: http://pjp.dgplug.org/tools/whereami-1.0.tar.gz SRPM: http://pjp.dgplug.org/tools/whereami-1.0-1.fc12.src.rpm Thank you.
Is there a reason, why you use %post and %postun for linking %{_bindir}/wmi? It would be nicer, if you'd do that in %install and add that file to %files.
And if you made a link for the executable, make one for the manpage.
Hi, thanks for the comments. I've made the changes, please have a look at these latest files. SPEC: http://pjp.dgplug.org/tools/whereami.spec SORC: http://pjp.dgplug.org/tools/whereami-1.0.tar.gz SRPM: http://pjp.dgplug.org/tools/whereami-1.0-2.fc12.src.rpm Thank you.
Review: Good: - name ok - rpmlint ok $ rpmlint ./whereami-1.0-2.fc13.src.rpm x86_64/whereami-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. - description ok - %prep ok - %install looks a bit crazy, but ok - %clean there - %files ok - macros everywhere - no libs - no .la - arch ok - builds in mock: INFO: Done(whereami-1.0-2.fc13.src.rpm) Config(default) 1 minutes 6 seconds - %build see needswork Needswork/shouldwork: - configure: WARNING: unrecognized options: --disable-static - please use INSTALL="install -p" to preserve timestamps ############################################################################## There are only SHOULDS left. ############################################################################## APPROVED
Aah forgot to add: Good: - license ok: GPLv3+ - source matches upstream: 775b7544bcf45dfde962a357fcccc407
Cool, that was fast. :) Thank you.
New Package CVS Request ======================= Package Name: whereami Short Description: Displays work location Owners: pjp Branches: F-11 F-12 F-13 EL-5 InitialCC: pjp
CVS done (by process-cvs-requests.py).
whereami-1.0-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/whereami-1.0-2.fc13
whereami-1.0-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/whereami-1.0-2.el5
whereami-1.0-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/whereami-1.0-2.fc12
whereami-1.0-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
whereami-1.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
whereami-1.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: whereami New Branches: epel7 Owners: pjp
Git done (by process-git-requests).
whereami-1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/whereami-1.0-2.el6
whereami-1.0-9.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/whereami-1.0-9.el7
Package whereami-1.0-9.el7: * should fix your issue, * was pushed to the Fedora EPEL 7 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing whereami-1.0-9.el7' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-2388/whereami-1.0-9.el7 then log in and leave karma (feedback).
whereami-1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
whereami-1.0-9.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.