Spec URL: http://hicham.fedorapeople.org/firetray.spec SRPM URL: http://hicham.fedorapeople.org/firetray-0.2.5-0.1.fc13.src.rpm Description: Firetray is a system tray addon for mozilla, current features are : - adds tray icon for both firefox and thunderbird - Show number of unread mails in the tray icon (Thunderbird) - close button hides to tray - ability to start minimized to tray - when restoring if the window is iconified, deiconify it - Custom tray icon - Hotkey for Hide/Unhide - Multimedia keys grabbing to allow playback control in songbird - Handle mouse scrolls on tray icon
The package should maybe be called mozilla-firetray, since the two other extensions packaged in Fedora I know use a mozilla prefix, too: mozilla-noscript and mozilla-adblockplus.
OK, valid suggestion, I will take it into account
I will remove the symlinking scheme and use a copy for each program. Seems like firefox doesn't like symlinks very much.
Weird, icon is not shown fro other mozilla products, though listed in Addon Manager
Now it is only sunbird which doesn't show the systray icon, should I investigate more or just drop sunbird support from this extension ?
Now firefox, thunderbird, seamonkey and sunbird are all working with extension. I hope I can get back my internet connection soon.
Spec URL: http://hicham.fedorapeople.org/firetray.spec SRPM URL: http://hicham.fedorapeople.org/firetray-0.2.6-1.fc13.src.rpm
Spec URL: http://hicham.fedorapeople.org/mozilla-firetray.spec SRPM URL: http://hicham.fedorapeople.org/mozilla-firetray-0.2.6-1.fc13.src.rpm
Koji build pages : ------------------------------------------------------------------------------- F-14 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2226303 F-13 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2226325 F-12 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2226310 F-11 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2226320 ------------------------------------------------------------------------------- rpmlint output for binary rpms : ------------------------------------------------------------------------------- [hicham@hicham-laptop i686]$ rpmlint mozilla-firetray*.rpm mozilla-firetray-core.i686: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray-core.i686: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox mozilla-firetray-core.i686: W: spelling-error %description -l en_US thunderbird -> Thunderbird, thunder bird, thunder-bird mozilla-firetray-core.i686: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray-core.i686: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray-firefox.i686: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray-firefox.i686: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray-firefox.i686: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray-firefox.i686: W: only-non-binary-in-usr-lib mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/chrome /usr/lib/mozilla-firetray-0.2.6/chrome mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/install.rdf /usr/lib/mozilla-firetray-0.2.6/install.rdf mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/components/nsITray.xpt /usr/lib/mozilla-firetray-0.2.6/components/nsITray.xpt mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/components/nsMinimize.js /usr/lib/mozilla-firetray-0.2.6/components/nsMinimize.js mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/defaults /usr/lib/mozilla-firetray-0.2.6/defaults mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/chrome.manifest /usr/lib/mozilla-firetray-0.2.6/chrome.manifest mozilla-firetray-firefox.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{9533f794-00b4-4354-aa15-c2bbda6989f8}/components/nsIMinimize.xpt /usr/lib/mozilla-firetray-0.2.6/components/nsIMinimize.xpt mozilla-firetray-firefox.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-firefox-0.2.6/ChangeLog /usr/share/doc/mozilla-firetray-core-0.2.6/ChangeLog mozilla-firetray-firefox.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-firefox-0.2.6/COPYING /usr/lib/mozilla-firetray-0.2.6/License.txt mozilla-firetray-seamonkey.i686: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray-seamonkey.i686: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray-seamonkey.i686: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray-seamonkey.i686: W: invalid-url URL: http://code.google.com/p/firetray <urlopen error [Errno -2] Name or service not known> mozilla-firetray-seamonkey.i686: W: only-non-binary-in-usr-lib mozilla-firetray-seamonkey.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}/{9533f794-00b4-4354-aa15-c2bbda6989f8} /usr/lib/mozilla-firetray-0.2.6 mozilla-firetray-seamonkey.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-seamonkey-0.2.6/ChangeLog /usr/share/doc/mozilla-firetray-core-0.2.6/ChangeLog mozilla-firetray-seamonkey.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-seamonkey-0.2.6/COPYING /usr/lib/mozilla-firetray-0.2.6/License.txt mozilla-firetray-sunbird.i686: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray-sunbird.i686: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray-sunbird.i686: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray-sunbird.i686: W: invalid-url URL: http://code.google.com/p/firetray <urlopen error [Errno -2] Name or service not known> mozilla-firetray-sunbird.i686: W: only-non-binary-in-usr-lib mozilla-firetray-sunbird.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-sunbird-0.2.6/ChangeLog /usr/share/doc/mozilla-firetray-core-0.2.6/ChangeLog mozilla-firetray-sunbird.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-sunbird-0.2.6/COPYING /usr/lib/mozilla-firetray-0.2.6/License.txt mozilla-firetray-sunbird.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{718e30fb-e89b-41dd-9da7-e25a45638b28}/{9533f794-00b4-4354-aa15-c2bbda6989f8} /usr/lib/mozilla-firetray-0.2.6 mozilla-firetray-thunderbird.i686: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray-thunderbird.i686: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray-thunderbird.i686: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray-thunderbird.i686: W: invalid-url URL: http://code.google.com/p/firetray <urlopen error [Errno -2] Name or service not known> mozilla-firetray-thunderbird.i686: W: only-non-binary-in-usr-lib mozilla-firetray-thunderbird.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-thunderbird-0.2.6/COPYING /usr/lib/mozilla-firetray-0.2.6/License.txt mozilla-firetray-thunderbird.i686: W: dangling-symlink /usr/lib/mozilla/extensions/{3550f703-e582-4d05-9a08-453d09bdfdc6}/{9533f794-00b4-4354-aa15-c2bbda6989f8} /usr/lib/mozilla-firetray-0.2.6 mozilla-firetray-thunderbird.i686: W: dangling-symlink /usr/share/doc/mozilla-firetray-thunderbird-0.2.6/ChangeLog /usr/share/doc/mozilla-firetray-core-0.2.6/ChangeLog 6 packages and 0 specfiles checked; 0 errors, 42 warnings. ------------------------------------------------------------------------------- rpmlint output for spec file : ------------------------------------------------------------------------------- [hicham@hicham-laptop SPECS]$ rpmlint mozilla-firetray.spec mozilla-firetray.spec:34: W: macro-in-comment %{rev} mozilla-firetray.spec:36: W: macro-in-comment %{upname} mozilla-firetray.spec:36: W: macro-in-comment %{version} mozilla-firetray.spec:36: W: macro-in-comment %{rev} mozilla-firetray.spec:37: W: macro-in-comment %{upname} mozilla-firetray.spec:37: W: macro-in-comment %{version} mozilla-firetray.spec:37: W: macro-in-comment %{rev} mozilla-firetray.spec:37: W: macro-in-comment %{upname} mozilla-firetray.spec:37: W: macro-in-comment %{version} mozilla-firetray.spec:37: W: macro-in-comment %{rev} mozilla-firetray.spec:47: W: macro-in-comment %{optflags} ------------------------------------------------------------------------------- rpmlint output for srpm : ------------------------------------------------------------------------------- [hicham@hicham-laptop SRPMS]$ rpmlint mozilla-firetray*.rpm mozilla-firetray.src: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox mozilla-firetray.src: W: spelling-error %description -l en_US thunderbird -> Thunderbird, thunder bird, thunder-bird mozilla-firetray.src: W: spelling-error %description -l en_US iconified -> dignified, magnified, iconic mozilla-firetray.src: W: spelling-error %description -l en_US deiconify -> demagnify, personify, deification mozilla-firetray.src: W: strange-permission firetray-0.2.6.tar.gz 0755L mozilla-firetray.src:34: W: macro-in-comment %{rev} mozilla-firetray.src:36: W: macro-in-comment %{upname} mozilla-firetray.src:36: W: macro-in-comment %{version} mozilla-firetray.src:36: W: macro-in-comment %{rev} mozilla-firetray.src:37: W: macro-in-comment %{upname} mozilla-firetray.src:37: W: macro-in-comment %{version} mozilla-firetray.src:37: W: macro-in-comment %{rev} mozilla-firetray.src:37: W: macro-in-comment %{upname} mozilla-firetray.src:37: W: macro-in-comment %{version} mozilla-firetray.src:37: W: macro-in-comment %{rev} mozilla-firetray.src:47: W: macro-in-comment %{optflags} -------------------------------------------------------------------------------
i can silence the dangling symlinks warnings by explicity providing the required targets in core, and requiring them in the other subpackages, but i don't know if it is worth it
seems like this is getting nowhere, closing
reopening since the i added a "fix" to the incorrect unread mail issue Spec URL: http://hicham.fedorapeople.org/firetray.spec SRPM URL: http://hicham.fedorapeople.org/mozilla-firetray-0.2.8-1.fc13.src.rpm Description: Firetray is a system tray addon for mozilla, current features are : - adds tray icon for both firefox and thunderbird - Show number of unread mails in the tray icon (Thunderbird) - close button hides to tray - ability to start minimized to tray - when restoring if the window is iconified, deiconify it - Custom tray icon - Hotkey for Hide/Unhide - Multimedia keys grabbing to allow playback control in songbird - Handle mouse scrolls on tray icon
oops Spec URL: http://hicham.fedorapeople.org/mozilla-firetray.spec SRPM URL: http://hicham.fedorapeople.org/mozilla-firetray-0.2.8-1.fc13.src.rpm Description: Firetray is a system tray addon for mozilla, current features are : - adds tray icon for both firefox and thunderbird - Show number of unread mails in the tray icon (Thunderbird) - close button hides to tray - ability to start minimized to tray - when restoring if the window is iconified, deiconify it - Custom tray icon - Hotkey for Hide/Unhide - Multimedia keys grabbing to allow playback control in songbird - Handle mouse scrolls on tray icon
Koji build pages : F14 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2324745 F13 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2324781 F12 : http://koji.fedoraproject.org/koji/taskinfo?taskID=2324754
NO - Package meets naming and packaging guidelines FIXME: Package should be named firetray as that is the name of the upstream project YES - Spec file matches base package name. YES - Spec has consistant macro usage. - Meets Packaging Guidelines. YES - License YES - License field in spec matches YES - License file included in package YES - Spec in American English YES - Spec is legible. NO - Sources match upstream md5sum: Invalid Source0 URL Source0: http://%{upname}.googlecode.com/files/%{upname}-%{version}-src.zip NA - Package needs ExcludeArch YES - BuildRequires correct NA - Spec handles locales/find_lang NA - Package is relocatable and has a reason to be. YES - Package has %defattr and permissions on files is good. YES - Package has a correct %clean section. YES - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) YES - Package is code or permissible content. NA - Doc subpackage needed/used. YES - Packages %doc files don't affect runtime. NA - Headers/static libs in -devel subpackage. NA - Spec has needed ldconfig in post and postun NA - .pc files in -devel subpackage/requires pkgconfig NA - .so files in -devel subpackage. NA- -devel package Requires: %{name} = %{version}-%{release} NA - .la files are removed. NA - Package is a GUI app and has a .desktop file YES - Package compiles and builds on at least one arch. YES - Package has no duplicate files in %files. YES - Package doesn't own any directories other packages own. YES - Package owns all the directories it creates. NO - No rpmlint output. [10:49:31][adam@turnip][SPECS]+ rpmlint ../SRPMS/mozilla-firetray-0.2.8-1.fc13.src.rpm mozilla-firetray.src: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US addon -> ad don, ad-don, add on mozilla-firetray.src: W: spelling-error %description -l en_US firefox -> Firefox, firebox, fire fox mozilla-firetray.src: W: spelling-error %description -l en_US thunderbird -> Thunderbird, thunder bird, thunder-bird mozilla-firetray.src: W: spelling-error %description -l en_US iconified -> personified, iconicity, nonunified mozilla-firetray.src: W: spelling-error %description -l en_US deiconify -> deification, personify, Delmonico mozilla-firetray.src:79: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version} mozilla-firetray.src:80: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/License.txt mozilla-firetray.src:81: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/defaults mozilla-firetray.src:82: W: unversioned-explicit-provides %{_datadir}/doc/%{name}-core-%{version}/ChangeLog mozilla-firetray.src:83: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/install.rdf mozilla-firetray.src:84: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/chrome mozilla-firetray.src:85: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/chrome.manifest mozilla-firetray.src:86: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsITray.xpt mozilla-firetray.src:87: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsMinimize.js mozilla-firetray.src:88: W: unversioned-explicit-provides %{_libdir}/%{name}-%{version}/components/nsIMinimize.xpt mozilla-firetray.src: W: invalid-url Source0: http://firetray.googlecode.com/files/firetray-0.2.8-src.zip HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 17 warnings. YES - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) [10:50:36][adam@turnip][result]+ for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done mozilla-firetray-0.2.8-1.fc13.src.rpm = xulrunner-devel scons zip unzip rpmlib(FileDigests) <= 4.6.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mozilla-firetray-chatzilla-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-chatzilla = 0.2.8-1.fc13 mozilla-firetray-chatzilla(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog chatzilla mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-core-0.2.8-1.fc13.x86_64.rpm /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog libnptray.so()(64bit) mozilla-firetray-core = 0.2.8-1.fc13 mozilla-firetray-core(x86-64) = 0.2.8-1.fc13 = libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-debuginfo-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-debuginfo = 0.2.8-1.fc13 mozilla-firetray-debuginfo(x86-64) = 0.2.8-1.fc13 = rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-firefox-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-firefox = 0.2.8-1.fc13 mozilla-firetray-firefox(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/lib64/mozilla-firetray-0.2.8/chrome /usr/lib64/mozilla-firetray-0.2.8/chrome.manifest /usr/lib64/mozilla-firetray-0.2.8/components/nsIMinimize.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsITray.xpt /usr/lib64/mozilla-firetray-0.2.8/components/nsMinimize.js /usr/lib64/mozilla-firetray-0.2.8/defaults /usr/lib64/mozilla-firetray-0.2.8/install.rdf /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog firefox mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-seamonkey-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-seamonkey = 0.2.8-1.fc13 mozilla-firetray-seamonkey(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 seamonkey rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-sunbird-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-sunbird = 0.2.8-1.fc13 mozilla-firetray-sunbird(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 sunbird rpmlib(PayloadIsXz) <= 5.2-1 mozilla-firetray-thunderbird-0.2.8-1.fc13.x86_64.rpm mozilla-firetray-thunderbird = 0.2.8-1.fc13 mozilla-firetray-thunderbird(x86-64) = 0.2.8-1.fc13 = /usr/lib64/mozilla-firetray-0.2.8 /usr/lib64/mozilla-firetray-0.2.8/License.txt /usr/share/doc/mozilla-firetray-core-0.2.8/ChangeLog mozilla-firetray-core = 0.2.8 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 thunderbird rpmlib(PayloadIsXz) <= 5.2-1 SHOULD Items: YES - Should build in mock. YES - Should build on all supported archs YES - Should function as described. NA - Should have sane scriptlets. YES - Should have subpackages require base package with fully versioned depend. YES - Should have dist tag YES - Should package latest version NA - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Not really an issue, but a suggestion to changing the %define macros to %global. 2. Fix the line items with a "NO" on them from the review.
as you can see in comment 1, i was using firetray as a name, but others suggested that it should be named mozilla-firetray like mozilla-adblockplus and mozilla-noscript. for the rpmlint output, i don't think it is possible to remove it, because all solutions generate warnings : - If i only add mozilla-firetray-core as a dep, rpmlint complains about dangling symlinks in mozilla-firetray-<app> - If I provide the files in mozilla-firetray-core and require them in mozilla-firetray-<app>, I get a non versioned provides. - If I version the provides, I get a warning that files provides shouldn't be versioned.
(In reply to comment #15) > NO - Package meets naming and packaging guidelines > FIXME: Package should be named firetray as that is the name of the upstream > project I'd like to point out here that several (all?) existing Mozilla extensions in Fedora repos have mozilla- prefix: mozilla-adblockplus.noarch : Adblocking extension for Mozilla Firefox mozilla-noscript.noarch : JavaScript white list extension for Mozilla Firefox It would be really nice to have uniform packaging guidelines for Mozilla extensions where one could, among other things, get a sample spec file and answers to the following questions: - how to name the source rpm? - how to split files between subpackages if the extension works in several different browsers? For example, should there be a -core subpackage plus a separate subpackage for each browser? (that's what this spec is doing) Or, should we have one package which registers the extension for all browsers? - how to name subpackages? - should subpackages depend on the programs (Firefox, Thunderbird, etc.) they are extending? Debian's guidelines are here: http://wiki.debian.org/mozilla-devscripts They are naming their source package EXTENSIONNAME and binary package as xul-ext-EXTENSIONNAME Hicam, perhaps you could come up with short guidelines and run it through Fedora Packaging Committee first?
(In reply to comment #17) > (In reply to comment #15) > > NO - Package meets naming and packaging guidelines > > FIXME: Package should be named firetray as that is the name of the upstream > > project > > I'd like to point out here that several (all?) existing Mozilla extensions in > Fedora repos have mozilla- prefix: > mozilla-adblockplus.noarch : Adblocking extension for Mozilla Firefox > mozilla-noscript.noarch : JavaScript white list extension for Mozilla Firefox > > It would be really nice to have uniform packaging guidelines for Mozilla > extensions where one could, among other things, get a sample spec file and > answers to the following questions: > - how to name the source rpm? + we name source rpm according to the spec name. > - how to split files between subpackages if the extension works in > several different browsers? For example, should there be a -core > subpackage plus a separate subpackage for each browser? (that's what this > spec is doing) Or, should we have one package which registers the > extension for all browsers? + I think forcing all mozilla applications to use it is just insane. For example, a user might need it for Thunderbird, but not for Firefox. > - how to name subpackages? + The naming scheme that I followed seems rational to me, if you have another suggestion, it is welcome > - should subpackages depend on the programs (Firefox, Thunderbird, etc.) > they are extending? + Yes, because they depend on directories owned by these, and they don't make sense without the appropriate application installed. > > Debian's guidelines are here: http://wiki.debian.org/mozilla-devscripts > They are naming their source package EXTENSIONNAME and binary package as > xul-ext-EXTENSIONNAME I don't think that this naming scheme can be applied in Fedora. > > Hicam, perhaps you could come up with short guidelines and run it through > Fedora Packaging Committee first? This is beyond the scope of this bug, you can open a ticket where appropriate to discuss that.
(In reply to comment #18) > (In reply to comment #17) > > It would be really nice to have uniform packaging guidelines for Mozilla > > extensions where one could, among other things, get a sample spec file and > > answers to the following questions: > > - how to name the source rpm? > > + we name source rpm according to the spec name. Well, in that case the question is: - how to name the spec file + srpm? > > Hicam, perhaps you could come up with short guidelines and run it through > > Fedora Packaging Committee first? > > This is beyond the scope of this bug, you can open a ticket where appropriate > to discuss that. Adam and you are having a disagreement over the naming here. I'm trying to help you solve the disagreement. One way to do that is for you to come up with short guidelines. You already answered to most of the questions above; copy paste it all together to a wiki page and post it for FPC review. I would be happy to look over the text once you've written a draft.
(In reply to comment #17) > (In reply to comment #15) > > NO - Package meets naming and packaging guidelines > > FIXME: Package should be named firetray as that is the name of the upstream > > project > > I'd like to point out here that several (all?) existing Mozilla extensions in > Fedora repos have mozilla- prefix: > mozilla-adblockplus.noarch : Adblocking extension for Mozilla Firefox > mozilla-noscript.noarch : JavaScript white list extension for Mozilla Firefox > > It would be really nice to have uniform packaging guidelines for Mozilla > extensions where one could, among other things, get a sample spec file and > answers to the following questions: > - how to name the source rpm? > - how to split files between subpackages if the extension works in > several different browsers? For example, should there be a -core > subpackage plus a separate subpackage for each browser? (that's what this > spec is doing) Or, should we have one package which registers the > extension for all browsers? > - how to name subpackages? > - should subpackages depend on the programs (Firefox, Thunderbird, etc.) > they are extending? > > Debian's guidelines are here: http://wiki.debian.org/mozilla-devscripts > They are naming their source package EXTENSIONNAME and binary package as > xul-ext-EXTENSIONNAME > > Hicam, perhaps you could come up with short guidelines and run it through > Fedora Packaging Committee first? I agree it would be nice to have uniform naming conventions on this, but as it stands there is none as per http://fedoraproject.org/wiki/PackageNamingGuidelines and this package is not upstream as mozilla-firetray but as firetray. -AdamM
Placing review on hold awaiting clarification on the naming standard. -AdamM
(In reply to comment #20) > I agree it would be nice to have uniform naming conventions on this, but as it > stands there is none as per > http://fedoraproject.org/wiki/PackageNamingGuidelines and this package is not > upstream as mozilla-firetray but as firetray. There is a general addon packages naming guideline: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29
(In reply to comment #22) > (In reply to comment #20) > > > I agree it would be nice to have uniform naming conventions on this, but as it > > stands there is none as per > > http://fedoraproject.org/wiki/PackageNamingGuidelines and this package is not > > upstream as mozilla-firetray but as firetray. > > There is a general addon packages naming guideline: > https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 Welcome back Till, and thanks for helping us.
Ok, here is an alternate proposal, what do you think about renaming the core package to firetray and the other packages to <app>-firetray, would that make more sense according to https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29 ?
While I still don't agree with the naming situation, it does appear that this is how this sort of thing is currently being handled, so the name is fine as is. If you could fix the URL to the source, upload the spec and srpm and link me I will move forward with the review. -AdamM
Appears the failed md5sum was a false positive and the rpmlint output is not a blocker, I spoke with Hicham about them in irc. APPROVED
New Package CVS Request ======================= Package Name: mozilla-firetray Short Description: A system tray addon for mozilla Owners: hicham Branches: F-12 F-13 F-14 InitialCC: hicham
Git done (by process-git-requests).
mozilla-firetray-0.2.8-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/mozilla-firetray-0.2.8-1.fc13
mozilla-firetray-0.2.8-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/mozilla-firetray-0.2.8-1.fc14
mozilla-firetray-0.2.8-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mozilla-firetray-0.2.8-1.fc12
mozilla-firetray-0.2.8-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
mozilla-firetray-0.2.8-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
mozilla-firetray-0.2.8-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
firetray for thunderbird was showing double the count of mails, so yum erased it and installed the one provided by mozilla and it worked fine.
Same worked fine on my other F14 x86_64. so closing the issue.