Bug 583673
| Summary: | set-cpu_llc_id-on-amd-cpus patch: undefined variable 'cpu' in in amd_detect_cmp() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Igor Zhbanov <izh1979> | ||||
| Component: | kernel | Assignee: | Prarit Bhargava <prarit> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Mike Gahagan <mgahagan> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 5.5 | CC: | anton, izh1979, jwilson | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-13 21:28:29 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Red Hat does not support the building of custom kernels, however, we should be able to make this simple change. P. Created attachment 439674 [details]
RHEL5 fix for this issue
int cpu is defined w/o CONFIG_NUMA upstream. Even though a straight backport isn't viable, let's do the same in RHEL5.
P.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. in kernel-2.6.18-219.el5 You can download this test kernel from http://people.redhat.com/jwilson/el5 Detailed testing feedback is always welcomed. I was able to rebuild the -236 kernel with the numa config options turned off so this one can be verified. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2011-0017.html |
Description of problem: Hello! I have kernel-2.6.18-194.el5.src.rpm and cannot compile it. The problem is because variable 'cpu' is undefined in arch/x86_64/kernel/setup.c in function amd_detect_cmp(): static void __init amd_detect_cmp(struct cpuinfo_x86 *c) { ... #ifdef CONFIG_NUMA int cpu = smp_processor_id(); ... #endif ... /* use socket ID also for last level cache */ cpu_llc_id[cpu] = c->phys_proc_id; ... #ifdef CONFIG_NUMA ... #endif ... } As you can see, variable 'cpu' is defined only when CONFIG_NUMA is set. But this variable unconditionally used few lines below. I suppose that it should be defined unconditionally or it's usage should be moved inside CONFIG_NUMA ifdef. That lines are added in linux-2.6-x86-set-cpu_llc_id-on-amd-cpus.patch. Version-Release number of selected component (if applicable): kernel-2.6.18-194.el5.src.rpm How reproducible: Always Steps to Reproduce: Build kernel.