Bug 584592 - Inventory not UTF safe?
Summary: Inventory not UTF safe?
Alias: None
Product: Beaker
Classification: Retired
Component: tests
Version: 0.4
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Bill Peck
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2010-04-21 23:34 UTC by Matt Brodeur
Modified: 2010-06-02 17:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-06-02 17:29:21 UTC

Attachments (Terms of Use)

Description Matt Brodeur 2010-04-21 23:34:14 UTC
Description of problem:
I just managed to import a set of key/values which seems to upset the web UI greatly.  Loading certain systems or the Activity page results in a 500 error.

Version-Release number of selected component (if applicable):

As far as I can tell, this is because of a key/value which contains a non-ASCII character.  oocalc helpfully replaced several of my hyphens with en-dash, em-dash, or something else I didn't actually want.  The offending character is this one:

IBM RSA II – ibm-x3950m2-02-rsa.ovirt.rhts.eng.bos.redhat.com

I'm going to try to fix this in the DB to make beaker useful again, but I'd like to see a fix in the future.  Either beaker needs to handle extended characters, or the import process needs to reject them.

Comment 1 Kevin Baker 2010-04-21 23:53:36 UTC
I expect a test case to be built for this that works with UTF8 characters.

Comment 2 Raymond Mancy 2010-05-17 12:56:26 UTC
Looking at this...

Comment 3 Raymond Mancy 2010-05-24 01:58:01 UTC
If we want to deal properly with utf8, we need to do a couple more things.

1) Set up DB tables for utf8
2) Set up connector for utf8
3) Ensure the code deals in utf8 strings and not ascii
4) Display content/type as utf8

1 already is the case. 2 is easy.
3 is dealt with in some areas of the code, but it isn't systematic.
4 is already done.

Comment 4 Raymond Mancy 2010-06-01 11:34:48 UTC

This change enables System details to have UTF8 characters (not the system name though).
It also allows general viewing of UTF8 characters (although not in the URL).

Test is here


Comment 5 Bill Peck 2010-06-01 16:14:19 UTC
merged. will be in next release.

Comment 6 Kevin Baker 2010-06-01 22:35:13 UTC
(In reply to comment #4)

> Test is here
> https://beaker.engineering.redhat.com/tasks/3020    

Ray, thanks. is there a git link to the test source?

Be great if you could link from the beaker UI to the test source. But I think that is an RFE we have outstanding.

Comment 7 Raymond Mancy 2010-06-02 03:34:24 UTC
We keep them in CVS, try something like this:
cvs -d :ext:kbaker@cvs.devel.redhat.com:/cvs/dist co tests/distribution/beaker/import_utf8

Note You need to log in before you can comment on or make changes to this bug.