Red Hat Bugzilla – Bug 584974
Review Request: R-combinat - R routines for combinatorics
Last modified: 2010-07-13 03:54:29 EDT
Spec URL: http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-combinat.spec SRPM URL: http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-combinat-0.0-3.fc12.src.rpm Description: R routines for combinatorics
Having no answer from you on the devel mailing-list I only went quickly through this package. There are the few remarks I have: - Fix version The version of this package is 0.0.7 not 0.0 cf http://fedoraproject.org/wiki/Packaging:R#R_version (Why did you change compare to R-bitops ?) - Fix %check Package builds fine with the %check here - Fix %changelog Please update the format of the changelog, the version-release should be on the same line as the changelog entry. This point is valid for at least R-bitops to.
(In reply to comment #1) > Having no answer from you on the devel mailing-list I only went quickly through > this package. > > There are the few remarks I have: > - Fix version > The version of this package is 0.0.7 not 0.0 cf > http://fedoraproject.org/wiki/Packaging:R#R_version > (Why did you change compare to R-bitops ?) fault on my side i found the problem and forgot to fix it on all packages fixed > - Fix %check > Package builds fine with the %check here agreed and fixed > - Fix %changelog > Please update the format of the changelog, the version-release should be on > the same line as the changelog entry. > This point is valid for at least R-bitops to. http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs states that this format is valid, too. I prefer this as i often build on very small resolution-screens and would have to scroll otherwise.
new SRPM: http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-combinat-0.0.7-4.fc12.src.rpm
(In reply to comment #2) > (In reply to comment #1) > > - Fix version > > The version of this package is 0.0.7 not 0.0 cf > > http://fedoraproject.org/wiki/Packaging:R#R_version > > (Why did you change compare to R-bitops ?) > > fault on my side > i found the problem and forgot to fix it on all packages > fixed "I found the problem", do you know R2spec ?
With the changes made, there is the review: * source files match upstream: md5sum combinat_0.0-7.tar.gz 61f163db2d314df276786631e2d6d966 combinat_0.0-7.tar.gz md5sum rpmbuild/SOURCES/combinat_0.0-7.tar.gz 61f163db2d314df276786631e2d6d966 rpmbuild/SOURCES/combinat_0.0-7.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in koji ( http://koji.fedoraproject.org/koji/taskinfo?taskID=2152940 ). * package installs properly * rpmlint produces 4 warnings, safe to ignore (spelling). 2 packages and 0 specfiles checked; 0 errors, 4 warnings. * final provides and requires are sane * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. ** APPROVED **
New Package CVS Request ======================= Package Name: R-combinat Short Description: R routines for combinatorics Owners: cheese Branches: F-12 F-13 InitialCC: cheese
CVS done (by process-cvs-requests.py).
same remark about tex(latex)
R-combinat-0.0.7-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/R-combinat-0.0.7-5.fc12
R-combinat-0.0.7-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/R-combinat-0.0.7-5.fc13
R-combinat-0.0.7-5.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update R-combinat'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/R-combinat-0.0.7-5.fc13
R-combinat-0.0.7-5.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update R-combinat'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/R-combinat-0.0.7-5.fc12
Could we see this push to stable ?
R-combinat-0.0.7-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
R-combinat-0.0.7-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.