Bug 58537

Description of Problem:

/usr/lib/rpm/perl.req is overzealous in creating requirements based on "do" 
and "require" statements in perl.

Version-Release number of selected component (if applicable):

rpm-devel-4.0.3-1.03

SHELL SESSION TRANSCRIPT WITH COMMENTARY THAT SHOWS BUG
------------------------------------------------------------------

/usr/lib/rpm/perl.req is simply overzealous in creating requirements based 
on "do" and "require" statements in perl.

Often times perl scripts use a "do" statement to include a configuration file. 
These should not be added as dependencies.

Here is a test perl script that contains a "do" statement to include a 
configuration file. I've seen stuff like this before in software. When you 
run /usr/lib/rpm/perl.req it comes up with a bogus dependency:

# cat  perl-req-test02.pl
#!/usr/bin/perl

do '/etc/mything/myconfigfile.pl';

print $greeting;

# find perl-req-test02.pl | /usr/lib/rpm/perl.req
perl(::etc/mything/myconfigfile.pl)

You can see that "perl(::etc/mything/myconfigfile.pl)" is a bogus dependency 
which no package is going to provide.

RECOMENDED FIX
----------------------------------------------------------

The /usr/lib/rpm/perl.req script needs to be more careful about creating 
requirements from "do" and "require" statements.

I think that /usr/lib/rpm/perl.req should only create requirements for "use" 
and "require" statements which have arguments that clearly look like package 
names.

It's better to err on the side of not creating a requirement than creating to 
many, IMHO.