Bug 585754 (dbusmenu-qt) - Review Request: dbusmenu-qt - A Qt implementation of the DBusMenu protocol
Summary: Review Request: dbusmenu-qt - A Qt implementation of the DBusMenu protocol
Alias: dbusmenu-qt
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Thomas Janssen
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2010-04-25 22:52 UTC by Rex Dieter
Modified: 2010-06-10 19:21 UTC (History)
3 users (show)

Fixed In Version: dbusmenu-qt-0.3.3-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-05-11 20:38:33 UTC
Type: ---
thomasj: fedora-review+
j: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2010-04-25 22:52:17 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/libdbusmenu-qt/libdbusmenu-qt.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/libdbusmenu-qt/libdbusmenu-qt-0.3.2-1.fc13.src.rpm
This library provides a Qt implementation of the DBusMenu protocol.

The DBusMenu protocol makes it possible for applications to export and import their menus over DBus.

Comment 1 Rex Dieter 2010-04-25 22:53:26 UTC
Scratch build:

$ rpmlint *src.rpm x86_64/*.rpm
libdbusmenu-qt-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

Comment 2 Rex Dieter 2010-04-25 23:11:05 UTC
Spec URL:

* Sun Apr 25 2010 Rex Dieter <rdieter@fedoraproject.org> 0.3.2-2
- pkg rename s/libdbusmenu-qt/dbusmenu-qt/
- Provides: libdbusmenu-qt(-devel)

Comment 3 Thomas Janssen 2010-04-28 18:16:17 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. (uses provides)
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
NN - Package needs ExcludeArch
OK - BuildRequires correct
NN - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
NN - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}

NN - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane


Comment 4 Rex Dieter 2010-04-28 18:52:45 UTC
New Package CVS Request
Package Name: dbusmenu-qt
Short Description: A Qt implementation of the DBusMenu protocol
Owners: rdieter than kkofler
Branches: F-12 F-13

Comment 5 Jason Tibbitts 2010-04-29 02:13:54 UTC
CVS done (by process-cvs-requests.py).

Comment 6 Rex Dieter 2010-05-11 20:38:33 UTC
built for rawhide

Comment 7 Fedora Update System 2010-05-26 13:14:56 UTC
dbusmenu-qt-0.3.3-1.fc13 has been submitted as an update for Fedora 13.

Comment 8 Fedora Update System 2010-05-26 13:16:03 UTC
dbusmenu-qt-0.3.3-1.fc12 has been submitted as an update for Fedora 12.

Comment 9 Fedora Update System 2010-06-10 19:21:02 UTC
dbusmenu-qt-0.3.3-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2010-06-10 19:21:22 UTC
dbusmenu-qt-0.3.3-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.