Red Hat Bugzilla – Bug 586291
Review Request: cURLpp - - C++ wrapper for libcURL
Last modified: 2013-10-19 10:42:52 EDT
Spec URL: <http://dl.dropbox.com/u/6190834/Curlpp%20Package/curlpp.spec>
SRPM URL: <http://dl.dropbox.com/u/6190834/Curlpp%20Package/curlpp-0.7.3-1.fc13.src.rpm>
libcURL is described as: a free and easy-to-use client-side URL transfer library, supporting FTP, FTPS, HTTP, HTTPS, GOPHER, TELNET, DICT, FILE and LDAP. libcurl supports HTTPS certificates, HTTP POST, HTTP PUT, FTP uploading, kerberos, HTTP form based upload, proxies, cookies, user+password authentication, file transfer resume, http proxy tunneling and more!
libcurl is highly portable, it builds and works identically on numerous platforms, including Solaris, NetBSD, FreeBSD, OpenBSD, Darwin, HPUX, IRIX, AIX, Tru64, Linux, Windows, Amiga, OS/2, BeOs, Mac OS X, Ultrix, QNX, OpenVMS, RISC OS, Novell NetWare, DOS and more…
libcurl is free, thread-safe, IPv6 compatible, feature rich, well supported and fast.
First, I need to quote Daniel Stenberg, the maintener of libcURL:
You can use libcURL instantly from within your C++ programs. You don’t need cURLpp for that, cURLpp just adds an OO’ified layer that libcURL doesn’t normally provide.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
* It uses the C++ Standard Library structures instead of home made ones.
* It is exception safe. (see this)
* It is type safe.
My informal review:
Line 4: First word did not capitalized.
Line 18: Typo: "Supporting"
Line 19: Over 80 characters of width.
Line 20: Double spaced between "HTTP" and "certificates".
Line 24: This paragraph is sort of irrelevant.
Line 42, 43: Please put %post and %postun after %clean.
Please make all paragraphs more readable.
Package doesn't build in mock:
checking for boostlib >= 1.33.1... configure: error: We could not detect the boost libraries (version 1.33 or higher).
Also, you should at least add COPYING in %doc. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
Ping? Any update on this one?
Devil Wang, shouldn't we be hearing from you within one week, I'll close this review request.
(In reply to comment #6)
> Ping? Any update on this one?
> Devil Wang, shouldn't we be hearing from you within one week, I'll close this
> review request.
I was busy this week, i will update this package as soon as possible.
Thank you for your promptly response. I am looking forward to hearing from you.
Another 3 weeks without update have passed. Closing review as FAILED.
Devil Wang, should you or others be interested in submitting this package to Fedora, feel free to open a new review request.
Closing as NOTABUG as per: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
*** This bug has been marked as a duplicate of bug 723053 ***