Red Hat Bugzilla – Bug 587072
[PATCH] Fix tgt-admin logic error with shared accounts in targets.conf
Last modified: 2010-11-10 17:23:57 EST
Created attachment 409951 [details] Fix tgt-admin logic error with shared accounts in targets.conf Description of problem: I tried creating a targets.conf with multiple targets, all with the same outgoing account. This is a valid (and typical) configuration. Snippet from my targets.conf: <target iqn.1999-07.com.gurulabs:station1> backing-store /srv/iscsi-luns/station1 incominguser station1 letmein outgoinguser server1 itsreallyme </target> <target iqn.1999-07.com.gurulabs:station2> backing-store /srv/iscsi-luns/station2 incominguser station2 letmein outgoinguser server1 itsreallyme </target> <target iqn.1999-07.com.gurulabs:station3> backing-store /srv/iscsi-luns/station3 incominguser station3 letmein outgoinguser server1 itsreallyme </target> The current logic in tgt-admin doesn't support having the same account (incoming or outgoing) defined on multiple targets. The current logic always deletes an account and then adds an account when processing each target. The delete removes the account from any already configured targets. The end result is only the last target processed will have account configured. Attached is a tested patch to support the configuration above. I've sent the patch upstream already. The tgt-admin in RHEL5 suffers from the same problem.
Thanks for the patch and problem analysis. Adding devel ack and proposing for RHEL 6.0.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion.
Thanks again for the patch Dax!. Merged in scsi-target-utils-1.0.4-0.el6.
Verified that the patch for /usr/sbin/tgt-admin (bash script) is included in scsi-target-utils-1.0.4-3.el6 and that the same incoming and outgoing user can be created for multiple targets with similar config that the reported shows. # cat /etc/tgt/targets.conf default-driver iscsi <target iqn.2001-04.com.storageqe-05-a> backing-store /dev/loop0 incominguser station1 letmein outgoinguser server1 itsreallyme </target> <target iqn.2001-04.com.storageqe-05-b> backing-store /dev/loop0 incominguser station1 letmein outgoinguser server1 itsreallyme </target> <target iqn.2001-04.com.storageqe-05-c> backing-store /dev/loop0 incominguser station1 letmein outgoinguser server1 itsreallyme </target> # service tgtd restart Stopping SCSI target daemon: [ OK ] Starting SCSI target daemon: [ OK ] # tgt-admin --show Target 1: iqn.2001-04.com.storageqe-05-a ... Account information: station1 server1 (outgoing) ACL information: ALL Target 2: iqn.2001-04.com.storageqe-05-b ... Account information: station1 server1 (outgoing) ACL information: ALL Target 3: iqn.2001-04.com.storageqe-05-c ... Account information: station1 server1 (outgoing) ACL information: ALL
Red Hat Enterprise Linux 6.0 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you.