Spec URL: http://github.com/admiyo/MySpecs/blob/master/rubygem-echoe.spec SRPM URL: http://admiyo.fedorapeople.org/buildr-repo/rubygem-echoe-4.3-1.young.src.rpm Description: Echoe is a simple packaging tool for working with rubygems. It generates all the usual tasks for projects including rdoc generation, testing, packaging, and deployment. This package is a dependnecy for buildr
%ruby_sitelib is not used or needed in this spec. Please remove it. rpmlint rubygem-echoe-4.3-1.fc15.src.rpm rubygem-echoe.src: E: summary-too-long C A Rubygems packaging tool that provides Rake tasks for documentation, extension compiling, testing, and deployment rubygem-echoe.src:42: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab: line 42) 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint rubygem-echoe-4.3-1.fc15.noarch.rpm rubygem-echoe.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/compositepublisher.rb 0644L /usr/bin/env rubygem-echoe.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/ftptools.rb 0644L /usr/bin/env rubygem-echoe.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/rubyforgepublisher.rb 0644L /usr/bin/env rubygem-echoe.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/sys.rb 0644L /usr/bin/env rubygem-echoe.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/publisher.rb 0644L /usr/bin/env This section is not needed, and it even breaks trying to run the Rakefile in a %check (however this rakefile has no test/spec option) Please remove it. Files can marked as %doc outside of /usr/share/doc. mkdir -p %{buildroot}/usr/share/doc/%{gemdir}-%{version} for DOC in LICENSE CHANGELOG README TODO do mv %{buildroot}%{geminstdir}/$DOC %{buildroot}/usr/share/doc/%{gemdir}-%{version} done
ping.
Please correct name of this package, it's 'echoe', not echo. Also there are some typos as well: Review Request: rubygem-echo - ruby gem pacaking tool + if you are short of time, I can take this package.
What is the status of this bug? Although it is not strictly needed, if rubygem-echoe is available on Fedora it is preferable for bug 642572.
(In reply to comment #3) > Please correct name of this package, it's 'echoe', not echo. Also there are > some typos as well: > > Review Request: rubygem-echo - ruby gem pacaking tool > > + if you are short of time, I can take this package. Yes, definitely short on time. If you would like to take this package, I can give you what I have already.
(In reply to comment #4) > What is the status of this bug? Although it is not strictly > needed, if rubygem-echoe is available on Fedora it is preferable > for bug 642572. The status of the bug is not much movement has occurred. Current spec lives here: http://github.com/jmrodri/MySpecs/raw/master/rubygem-echoe/rubygem-echoe.spec
Current srpm can be found: http://jmrodri.fedorapeople.org/rubygem-echoe-4.3-2.fc13.src.rpm
* Wed Oct 27 2010 Michal Fojtik <mfojtik> 4.3.1-1 - Version bump - Fixed file list (marked doc files) - Removed vendored rake Spec URL: http://mifo.sk/RPMS/rubygem-echoe.spec SRPM URL: http://mifo.sk/RPMS/rubygem-echoe-4.3.1-1.fc13.src.rpm
Michal, are you going to review this ticket or be a maintainer for this package? A review request submitter cannot be the reviewer.
(In reply to comment #9) > Michal, are you going to review this ticket or be a maintainer > for this package? A review request submitter cannot be the reviewer. Oh yes, you are right. I willing to be a maintainer for this package.
(In reply to comment #10) > (In reply to comment #9) > > Michal, are you going to review this ticket or be a maintainer > > for this package? A review request submitter cannot be the reviewer. > > Oh yes, you are right. I willing to be a maintainer for this package. Okay, then I will look into this later.
Some notes * Unused macro - Defined macro %ruby_sitelib is used nowhere * Usability ------------------------------------------------------ $ ruby -rubygems -e "require 'echoe'" /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require': no such file to load -- /usr/lib/ruby/gems/1.8/gems/echoe-4.3.1/lib/../vendor/rake/lib/rake/contrib/compositepublisher (LoadError) from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' from /usr/lib/ruby/gems/1.8/gems/echoe-4.3.1/lib/echoe.rb:6 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from -e:1 ------------------------------------------------------ - Seems because vendorlized "rake" is removed. lib/echoe.rb also needs fixing (note that vendorlized rake should surely be removed)
(Just to clearify that I checked this: (In reply to comment #8) > * Wed Oct 27 2010 Michal Fojtik <mfojtik> 4.3.1-1 > - Version bump > - Fixed file list (marked doc files) > - Removed vendored rake > > Spec URL: http://mifo.sk/RPMS/rubygem-echoe.spec > SRPM URL: http://mifo.sk/RPMS/rubygem-echoe-4.3.1-1.fc13.src.rpm )
ping?
Sorry for late reply, here are updated files: * Tue Nov 09 2010 Michal Fojtik <mfojtik> 4.3.1-2 - Removed vendorized rake from echoe.rb - Removed unused site_lib macro ================ 4.3.1-2 ============= Spec URL: http://mifo.sk/RPMS/rubygem-echoe.spec SRPM URL: http://mifo.sk/RPMS/rubygem-echoe-4.3.1-2.fc14.src.rpm
One more comment ------------------------------------------------ rubygem-echoe.noarch: E: summary-too-long C A Rubygems packaging tool that provides Rake tasks for documentation, extension compiling, testing, and deployment ------------------------------------------------ - Please shorten "Summary" (to within 79 characters) ---------------------------------------------------------- This package (rubygem-echoe) is APPROVED by mtasaka ----------------------------------------------------------
Thanks for the review! New Package SCM Request ======================= Package Name: rubygem-echoe Short Description: A tool for packaging Ruby gems Owners: mfojtik Branches: f13 f14
Git done (by process-git-requests).
rubygem-echoe-4.3.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-echoe-4.3.1-2.fc13
rubygem-echoe-4.3.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-echoe-4.3.1-2.fc14
rubygem-echoe-4.3.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-echoe'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-echoe-4.3.1-2.fc14
Closing.
rubygem-echoe-4.3.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-echoe-4.3.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.