Bug 589705 - Update R template
Update R template
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: rpmdevtools (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Ville Skyttä
Fedora Extras Quality Assurance
:
Depends On: 593363
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-06 13:56 EDT by Pierre-YvesChibon
Modified: 2010-10-08 16:44 EDT (History)
2 users (show)

See Also:
Fixed In Version: 7.9-1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-05-20 16:37:38 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to change the template to the latest guidelines (2.08 KB, patch)
2010-05-06 13:56 EDT, Pierre-YvesChibon
no flags Details | Diff

  None (edit)
Description Pierre-YvesChibon 2010-05-06 13:56:53 EDT
Created attachment 412132 [details]
Patch to change the template to the latest guidelines

Description of problem:
The R template is outdated.

I am attaching to this bug a patch to correct the template to the latest version of the packaging guidelines.
Comment 1 Pierre-YvesChibon 2010-05-06 14:11:04 EDT
FYI, I kept in the template:
%global packname  %(echo %{name} | sed -e 's/^R-//')
although it does not work for me here (but I guess this should be a different bug)
Comment 2 Ville Skyttä 2010-05-06 15:18:17 EDT
I redid the patch because the one in initial comment contained apparently whitespace only changes that I don't think belong in the template (for consistency with others) and make it harder to see what's going on with the changes, please take a look at the git version to see if I missed something (and if I did, patches against that version are welcome).

http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=summary

Fixes also welcome to the %global packname thing if the current thing doesn't work.
Comment 3 Pierre-YvesChibon 2010-05-06 16:00:53 EDT
Looks good to me (pity for the spaces though, I liked when headers are aligned).

I have been discussing regarding:
%ifarch noarch
Requires:       R-core
%endif

It could be changed to a simple
Requires:       R-core # only needed for noarch

For the packname I'll see if I find something.
Comment 4 Ville Skyttä 2010-05-07 06:49:29 EDT
http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=commitdiff;h=594de67423252e833f987e048574e5d8974543f8
(Again for consistency with other spec templates)

I'll put this back to NEEDINFO regarding the packname issue.
Comment 5 Ville Skyttä 2010-05-18 11:53:38 EDT
I took a look at the packname issue and I now believe it is a problem in rpm, see bug 593363.  One workaround seems to be to use %define instead of %global.
Comment 6 Fedora Update System 2010-09-27 14:47:16 EDT
rpmdevtools-7.10-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rpmdevtools-7.10-1.fc13
Comment 7 Fedora Update System 2010-10-08 16:44:35 EDT
rpmdevtools-7.10-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.