RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 590580 - PATCH: libiscsi get_firmware_foo does not work without first creating a libiscsi context
Summary: PATCH: libiscsi get_firmware_foo does not work without first creating a libis...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: iscsi-initiator-utils
Version: 6.0
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Andy Grover
QA Contact: Barry Donahue
URL:
Whiteboard:
Depends On:
Blocks: 581428 590719 617860
TreeView+ depends on / blocked
 
Reported: 2010-05-10 08:39 UTC by Hans de Goede
Modified: 2012-06-26 16:26 UTC (History)
6 users (show)

Fixed In Version: iscsi-initiator-utils-6.2.0.872-4
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 590581 (view as bug list)
Environment:
Last Closed: 2010-11-10 20:42:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
PATCH: call sysfs_init from libiscsi_get_firmware_foo (1.38 KB, patch)
2010-05-10 08:39 UTC, Hans de Goede
no flags Details | Diff

Description Hans de Goede 2010-05-10 08:39:10 UTC
Created attachment 412756 [details]
PATCH: call sysfs_init from libiscsi_get_firmware_foo

Hi Mike,

The libiscsi_get_firmware_foo functions do not work without first creating a libiscsi context, while they are intended to work without a context. The problem is that the sysfs code needs to be initialized before use and it is used by
the fwparam code. This patch fixes this by calling sysfs_init() when
libiscsi_get_firmware_foo is called and sysfs_init was not called yet.

I'll clone this bug for 5.5 as I believe we need it there too.

Thanks & Regards,

Hans

p.s.

I can add this to pkg CVS myself if you want, but I'm not sure if I have commit rights there, only one way to find out I guess :)

Comment 1 RHEL Program Management 2010-05-10 09:22:34 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 2 Mike Christie 2010-05-10 17:39:12 UTC
(In reply to comment #0)
> I can add this to pkg CVS myself if you want, but I'm not sure if I have commit
> rights there, only one way to find out I guess :)    

Go ahead and commit.

If you cannot commit, then ping me, or ping whoever controls it to get those permissions since you maintain the userspace libiscsi and know the code well you should have those permissions.

Comment 3 Hans de Goede 2010-05-11 08:22:12 UTC
QA: this needs special hardware (ibft capable) to test, I'll verify this myself as soon as a build with the patch in has hit the nightlies. Can I get a QA ack on this please ?

Comment 4 Mike Christie 2010-05-19 11:54:26 UTC
Fixed in iscsi-initiator-utils-6.2.0.872-4.

Comment 9 Barry Donahue 2010-09-24 18:30:22 UTC
verified comment #6.

Comment 10 releng-rhel@redhat.com 2010-11-10 20:42:05 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.