Red Hat Bugzilla – Bug 591046
Wrong handling non-authorized method result with python-slip-polkit
Last modified: 2016-11-30 19:29:06 EST
Created attachment 413083 [details]
Possible solution for the issue
When I create a subclass of slip.dbus.service.Object, that provides some dbus methods without polkit authorization, this methods don't return value through dbus to the sender. Methods with polkit authorization is working as expected.
I might also figured out a solution, please see attached patch.
Created attachment 414089 [details]
Patch that is aware of returning tuples
The previous patch didn't work when a tuple was returned, this patch should work better.
Just returned from vacation. Are you using sync or async dbus methods?
I'm using sync methods. Strange thing is that example from slip works, but my code doesn't. If you want to try it, the error occurs when I try to call some methods from FMCI interface [ https://fedorahosted.org/fmci/wiki ].
Created attachment 417526 [details]
Patch for slip dbus
I have found another issue in python-slip code when I used python introspection. It eats some properties of method when the method is dbus interface. Try to run this code from directory with python-slip example:
server = imp.load_source("server", "example-conf-mechanism.py")
o = server.ExampleObject ()
The patch should correct the behavior. Now it chokes most parameters including __doc__, _slip_polkit_auth_required etc.
Ping, any progress?
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '12'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 12's end of life.
Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 12 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora please change the 'version' of this
bug to the applicable version. If you are unable to change the version,
please add a comment here and someone will do it for you.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
The process we are following is described here:
Argh, completely dropped the ball on this ticket, sorry.
(In reply to comment #4)
> Created attachment 417526 [details]
> Patch for slip dbus
Hmm, I'd rather not simply copy over stuff and hope that catching TypeError, ValueError will even things out ;-). Perhaps using the decorator module to build the decorator more cleanly would help...
> I have found another issue in python-slip code when I used python
> introspection. It eats some properties of method when the method is dbus
> interface. Try to run this code from directory with python-slip example:
> import imp
> server = imp.load_source("server", "example-conf-mechanism.py")
> o = server.ExampleObject ()
> The patch should correct the behavior. Now it chokes most parameters including
> __doc__, _slip_polkit_auth_required etc.
Ehm, why do you need to access the _slip_polkit_auth_required on the method? This is simply a flag added to the method by the decorator which is then used (and forgotten about) in the metaclass which will wrap the method in the polkit boiler plate code.
Sorry, I completely forgot about this bug. I used that in project that is dead now. So feel free to close this bug.