Bug 591312 - Review Request: maven-compiler-plugin - Maven Compiler Plugin
Summary: Review Request: maven-compiler-plugin - Maven Compiler Plugin
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeff Johnston
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-11 20:49 UTC by Alexander Kurtakov
Modified: 2010-05-14 14:20 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-05-14 14:20:20 UTC
jjohnstn: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2010-05-11 20:49:23 UTC
Spec URL: http://akurtakov.fedorapeople.org/maven-compiler-plugin.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-compiler-plugin-2.0.2-1.fc13.src.rpm
Description: The Compiler Plugin is used to compile the sources of your project.

Comment 1 Alexander Kurtakov 2010-05-11 20:54:15 UTC
Notes about this package:
- It uses version 2.0.2, which is not the latest, so that it can be built with
the current maven2-2.0.8; it will be updated to the newest version once the
newer maven is built
- It builds successfully in koji against the dist-f14-maven221
target: http://koji.fedoraproject.org/koji/taskinfo?taskID=2181317

Comment 2 Jeff Johnston 2010-05-12 16:20:47 UTC
According to the guidelines for maven spec files, jpackage-utils should be required.  In addition, the post and postun steps should require jpackage-utils.

Please fix or comment on the following rpmlint warnings/errors:

rpmlint on spec file:

maven-compiler-plugin.spec: W: invalid-url Source0: maven-compiler-plugin-2.0.2.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

rpmlint on binaries:

bash $ rpmlint maven-compiler-plugin-2.0.2-1.fc14.noarch.rpm 
maven-compiler-plugin.noarch: E: no-changelogname-tag
maven-compiler-plugin.noarch: W: unexpanded-macro Provides maven2-plugin-compiler = %{epoch}:2.0.2-1.fc14 %{epoch}
maven-compiler-plugin.noarch: W: no-documentation
maven-compiler-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-compiler-plugin
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

bash $ rpmlint maven-compiler-plugin-javadoc-2.0.2-1.fc14.noarch.rpm 
maven-compiler-plugin-javadoc.noarch: E: no-changelogname-tag
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

Comment 3 Alexander Kurtakov 2010-05-12 20:28:24 UTC
(In reply to comment #2)
> According to the guidelines for maven spec files, jpackage-utils should be
> required.  In addition, the post and postun steps should require
> jpackage-utils.
> 
Fixed.

> Please fix or comment on the following rpmlint warnings/errors:
> 
> rpmlint on spec file:
> 
> maven-compiler-plugin.spec: W: invalid-url Source0:
> maven-compiler-plugin-2.0.2.tar.xz
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
There is no source released from upstream just svn tag.


> 
> rpmlint on binaries:
> 
> bash $ rpmlint maven-compiler-plugin-2.0.2-1.fc14.noarch.rpm 
> maven-compiler-plugin.noarch: E: no-changelogname-tag
I can not see this one.

> maven-compiler-plugin.noarch: W: unexpanded-macro Provides
> maven2-plugin-compiler = %{epoch}:2.0.2-1.fc14 %{epoch}
Fixed.

> maven-compiler-plugin.noarch: W: no-documentation
No documentation provided.
> maven-compiler-plugin.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-compiler-plugin
False positive.
> 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
> 
> bash $ rpmlint maven-compiler-plugin-javadoc-2.0.2-1.fc14.noarch.rpm 
> maven-compiler-plugin-javadoc.noarch: E: no-changelogname-tag
I cannot see this.
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.    

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-compiler-plugin.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-compiler-plugin-2.0.2-2.fc13.src.rpm

Comment 4 Jeff Johnston 2010-05-12 21:13:54 UTC
Approved.

Comment 5 Alexander Kurtakov 2010-05-12 21:16:53 UTC
New Package CVS Request
=======================
Package Name: maven-compiler-plugin
Short Description: Maven Compiler Plugin
Owners: akurtakov
Branches: 
InitialCC:

Comment 6 Dennis Gilmore 2010-05-13 22:28:11 UTC
CVS Done

Comment 7 Alexander Kurtakov 2010-05-14 14:20:20 UTC
Built in rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=173429


Note You need to log in before you can comment on or make changes to this bug.