Bug 591632 - fix --update issue in F12
Summary: fix --update issue in F12
Alias: None
Product: Fedora
Classification: Fedora
Component: createrepo
Version: 12
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Luke Macken
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2010-05-12 17:58 UTC by Daniel Mach
Modified: 2016-09-20 02:40 UTC (History)
3 users (show)

Fixed In Version: createrepo-0.9.8-4.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-05-15 20:37:56 UTC
Type: ---

Attachments (Terms of Use)

Description Daniel Mach 2010-05-12 17:58:50 UTC
Following issue is not fixed in F12:

* Thu Jan  7 2010 Seth Vidal <skvidal at fedoraproject.org> - 0.9.8-4
- latest head with fixes for --update w/o --skipstat

Could you fix it there too?

Comment 1 seth vidal 2010-05-12 18:13:00 UTC
I can back port the --skip-stat/--update patch, sure.

But only if you test the pkg for me.

Comment 2 Daniel Mach 2010-05-12 18:21:06 UTC
Sure. What exactly you want me to test?
As far I can tell, converting st_mtime to int works in current F12 package so this only change should fix the problem. Do you want to back port whole createrepo-head.patch from F13 or just this fix?

Comment 3 seth vidal 2010-05-12 18:33:37 UTC
the distance between f12 and f13 is just 3 patches:

commit 0bf9a7f48786810515d4b530b91cb2bbd01a391c
Author: Dennis Gregorovic <dgregor@redhat.com>
Date:   Thu Jan 7 11:50:37 2010 -0500

    Fixed, convert stat mtime to int so comparison can work, --update, BZ 553030

commit c3b157d0ccc2a4c8971c64ec6f9fb4ea3a9c17c5
Author: Dennis Gregorovic <dgregor@redhat.com>
Date:   Thu Jan 7 00:11:14 2010 -0500

    Convert stat mtime to int so comparison can work, --update, BZ 553030

commit 044f521cadd42df029cfd75070defe699fe7f432
Author: Dennis Gregorovic <dgregor@redhat.com>
Date:   Wed Jan 6 15:26:58 2010 -0500

    Change baseurl of "old" packages on update, when baseurl specified

so I might just bring them all back.
it's easy.

Comment 4 seth vidal 2010-05-12 18:39:36 UTC
here you go:


Comment 5 Daniel Mach 2010-05-12 18:56:43 UTC
I have successfully verified the fix:

$ rpm -q createrepo

$ createrepo .; createrepo --verbose --update .
second run with --update is significantly faster and also prints correct messages:
Using data from old metadata for ...
(was: Modification time changed for ...)

Comment 6 Fedora Update System 2010-05-13 15:21:46 UTC
createrepo-0.9.8-4.fc12 has been submitted as an update for Fedora 12.

Comment 7 Fedora Update System 2010-05-15 20:37:52 UTC
createrepo-0.9.8-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.