Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be unavailable on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 592978 - Change Job detail page to use AJAX for showing results
Summary: Change Job detail page to use AJAX for showing results
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.5
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Raymond Mancy
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2010-05-17 14:27 UTC by Marian Csontos
Modified: 2019-05-22 13:33 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-05-26 17:17:21 UTC

Attachments (Terms of Use)

Description Marian Csontos 2010-05-17 14:27:44 UTC
Description of problem:
Opening J:640 results in ISE.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. https://beaker.engineering.redhat.com/jobs/640
Actual results:

Expected results:
Display details of the job

Additional info:
Time-stamp: 2010-05-17 14:25 GMT

Comment 1 Bill Peck 2010-05-20 15:19:33 UTC
This no longer produces an ISE 500 due to the proper config changes.

But I'm going to hijack this bug and request a change to the jobs page since even though it does work it doesn't scale. :-)


Currently we load all task results for every recipe at display time and hide them with css until someone clicks on either "Show All" or "Show Failures".  This works fine for small jobs but for jobs like 640 it fails miserably.

I'm suggesting we don't load the task results at all and change the buttons "Show All" and "Show Failures" to use ajax calls and those results would display in the div.

Let me know if you have any questions.  I'm raising the priority on this bug since I think this is the most important bug for you to work on right now.  I'd like to shoot for next Wednesday deployment if possible.


Comment 2 Raymond Mancy 2010-05-21 07:37:54 UTC
I've put it up on beaker-devel.bne
It will make an Ajax call for the first time you click on one of the buttons.


Comment 3 Bill Peck 2010-05-21 14:08:02 UTC
Your awesome Ray!

Merged.  will go out in next release.

Comment 4 Bill Peck 2010-05-21 14:55:07 UTC
I found one issue while testing.

If you have a "Show All" or "Show Failed" results open and then click through to see a log then click back it doesn't show the task runs from the ajax call.

I think the logic will need to be moved to the show routines?

Comment 5 Bill Peck 2010-05-21 19:12:45 UTC
Hi Ray,

I didn't get a chance to fix the not loading problem.. but I did fix the following things that I also found wrong. :-)

      - fix ajax call to order tasks correctly when viewing from recipe.
      - turn off pagination when viewing from recipe.
      - Always show logs

Please do a git pull before making any fixes. :-)

Comment 6 Bill Peck 2010-05-21 19:26:57 UTC
Show Failed results doesn't work unless you did "Show All" results first. :-)

Comment 7 Bill Peck 2010-05-21 20:38:45 UTC
Ok, I think its all good now.  I just moved your call into the show_all and show_fail methods.

Will be in next release.

Note You need to log in before you can comment on or make changes to this bug.