Hide Forgot
Created attachment 415302 [details] one-line patch resolving this issue Description of problem: RHEL6's libvirt silently ignores interface name specifications containing periods, though the kernel allows such interface names to be created. Version-Release number of selected component (if applicable): libvirt-0.8.1-1 How reproducible: 100% Steps to Reproduce: 1. use "virsh define" to create a VM configured to attach to a precreated tap device named including a period, using an interface definition such as the following: <interface type="ethernet"> <script path="/bin/true"/> <target dev="rtrtap-fvte.br67"/> <model type="virtio"/> </interface> 2. Run "virsh dumpxml" to display the domain XML for the freshly defined interface. Actual results: The domain XML will have the target element silently removed, as in the following example: <interface type="ethernet"> <mac address='00:16:3e:0b:9c:93'/> <script path="/bin/true"/> <model type="virtio"/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </interface> Expected results: The designated target element should remain present. Additional info: A patch I am using to successfully work around the issue is attached. This patch was also posted to the libvirt mailing list, as archived at http://permalink.gmane.org/gmane.comp.emulators.libvirt/25154
Created attachment 415520 [details] Updated patch removing isValidIfname entirely After more discussion on the mailing list, consensus appears to be jelling that the appropriate course of action is to remove interface name validity checking from the parse process entirely. See for instance the post by Chris Lalancette at http://permalink.gmane.org/gmane.comp.emulators.libvirt/25191
Created attachment 415533 [details] Updated patch removing isValidIfname entirely Updated version based on on-list feedback -- removes unnecessary header changes.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion.
Merged upstream commit 8583b947b15775ebb3dba8790dfa4487448c3d9b Author: Chris Lalancette <clalance@redhat.com> Date: Thu May 20 13:20:24 2010 -0400 Remove isValidIfname. We shouldn't be checking validity in domain_conf, since it can be used by multiple different hosts and hypervisors. Remove the check completely. Signed-off-by: Chris Lalancette <clalance@redhat.com>
libvirt-0_8_1-11_el6 has been built in RHEL-6-candidate with the fix. Dave
[root@dhcp-66-65-163 SOURCES]# rpm -q libvirt libvirt-0.8.1-13.el6.x86_64 1. [root@dhcp-66-65-163 SOURCES]# tunctl -t tap.test 2. insert following xml info domain toy'xml <interface type="ethernet"> <script path="/bin/true"/> <target dev="tap.test"/> <model type="virtio"/> </interface> 3. destroy toy 4. start toy 5. virsh dumpxml toy <domain type='kvm'> <name>toy</name> <uuid>78be5f39-fcd3-ba4f-e244-e2be4210b2f8</uuid> <memory>1048576</memory> <currentMemory>1048576</currentMemory> <vcpu>1</vcpu> <os> <type arch='x86_64' machine='rhel6.0.0'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> <pae/> </features> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='disk'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/migrate/bill2.img'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' unit='0'/> </disk> <controller type='ide' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='fdc' index='0'/> <interface type='network'> <mac address='52:54:00:f0:eb:5f'/> <source network='default'/> <target dev='vnet0'/> <filterref filter='disallow-dhcp'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </interface> <interface type='ethernet'> <mac address='52:54:00:a3:ab:05'/> <script path='/bin/true'/> <target dev='tap.test'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </interface> <serial type='pty'> <target port='0'/> </serial> <console type='pty'> <target port='0'/> </console> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='en-us'/> <sound model='ac97'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </sound> <sound model='es1370'> <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> </sound> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> </devices> </domain> the "target" node still stand there. Verified - Osier
Red Hat Enterprise Linux 6.0 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you.