Bug 594040 - Review Request: apache-commons-fileupload - rename of jakarta-commons-fileupload
Review Request: apache-commons-fileupload - rename of jakarta-commons-fileupload
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Alexander Kurtakov
Fedora Extras Quality Assurance
:
Depends On:
Blocks: JakartaCommonsRename
  Show dependency treegraph
 
Reported: 2010-05-20 08:25 EDT by Stanislav Ochotnicky
Modified: 2010-05-21 05:56 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-05-21 05:56:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
akurtako: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Stanislav Ochotnicky 2010-05-20 08:25:32 EDT
Spec URL: http://sochotni.fedorapeople.org/apache-commons-fileupload.spec
SRPM URL: http://sochotni.fedorapeople.org/apache-commons-fileupload-1.2.1-2.fc12.src.rpm

Description: The javax.servlet package lacks support for rfc 1867, html file upload.  This package provides a simple to use api for working with such data.  The scope of this package is to create a utility classes to read multipart/form-data within a javax.servlet.http.HttpServletRequest
Comment 1 Alexander Kurtakov 2010-05-20 09:34:34 EDT
I'll take this one.
Comment 2 Alexander Kurtakov 2010-05-20 10:05:28 EDT
Review:

OK: rpmlint must be run on every package. OUTPUT:

apache-commons-fileupload-javadoc.noarch: W: obsolete-not-provided jakarta-commons-fileupload-javadoc
Just obsoleting documentation package is OK

apache-commons-fileupload.noarch: W: spelling-error Summary(en_US) api -> pi, ape, apt
apache-commons-fileupload.noarch: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US javax -> java, java x, Java
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US servlet -> servile, serviette, servility
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US rfc -> RFC, rec, Pfc
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US api -> pi, ape, apt
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US multipart -> multiparty, multiplier, multiplexer
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US http -> HTTP
apache-commons-fileupload.noarch: W: spelling-error %description -l en_US HttpServletRequest 
apache-commons-fileupload.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-fileupload

Not a problem. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. 
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. Javadocs
subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK Packages must not own files or directories already owned by other
packages. 
OK: All filenames in rpm packages must be valid UTF-8.
OK: Package is correctly Obsoleting/Providing the old jakarta package. 

Things to fix:
* javadoc package is missing Requires:  jpackage-utils
Comment 3 Stanislav Ochotnicky 2010-05-20 10:29:05 EDT
Spec URL: http://sochotni.fedorapeople.org/apache-commons-fileupload.spec
SRPM URL:
http://sochotni.fedorapeople.org/apache-commons-fileupload-1.2.1-3.fc12.src.rpm


I am sorry but I also forgot to mention that this is a RE-REVIEW. So review provides/obsoletes separately.
Comment 4 Alexander Kurtakov 2010-05-20 10:32:31 EDT
(In reply to comment #3)
> Spec URL: http://sochotni.fedorapeople.org/apache-commons-fileupload.spec
> SRPM URL:
> http://sochotni.fedorapeople.org/apache-commons-fileupload-1.2.1-3.fc12.src.rpm
> 
> 
> I am sorry but I also forgot to mention that this is a RE-REVIEW. So review
> provides/obsoletes separately.    

I've noticed and checked that.

This package is APPROVED.
Comment 5 Stanislav Ochotnicky 2010-05-20 10:58:40 EDT
New Package CVS Request
=======================
Package Name: apache-commons-fileupload
Short Description: This package makes it easy to add robust, high-performance, file upload capability to your servlets and web applications.
Owners: sochotni
Branches: 
InitialCC:
Comment 6 Kevin Fenzi 2010-05-20 15:45:13 EDT
CVS done (by process-cvs-requests.py).
Comment 7 Stanislav Ochotnicky 2010-05-21 05:56:12 EDT
Thanks.

Package built-> Closing

Note You need to log in before you can comment on or make changes to this bug.