Description of problem: The patch linux-2.6.9-tty-fix-tty-holes.patch inside the source rpm from http://ftp.redhat.com/pub/redhat/linux/updates/enterprise/4WS/en/os/SRPMS/kernel-2.6.9-89.0.25.EL.src.rpm (released in RHSA-2010-0394) has a minor typo that breaks the compilation: drivers/net/irda/irtty-sir.c: In function `irtty_chars_in_buffer': drivers/net/irda/irtty-sir.c:65: error: structure has no member named `drivers' make[1]: *** [drivers/net/irda/irtty-sir.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: *** Waiting for unfinished jobs.... make: *** [_module_drivers/net/irda] Error 2 The correct member name inside priv->tty structure is "driver" (without "s"), not "drivers". Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Rebuild the source rpm 2. 3. Actual results: Compilation breaks. Expected results: Compile with no issues. Additional info:
I'll let Vitaly decide how to fix this one (and wonder how it got out the door).
Obviously, kernel rebuilds ok from src.rpm. I'm not sure, how Murilo does his build, but RHEL-4 has # CONFIG_IRDA is not set That said, IRDA is not supported in RHEL-4 and is not compiled during our build process. This is the reason, why IRDA is broken: developer of tty patch simply haven't ever seen this compile error. Murilo, I'm sorry, but there's no chance to commit patch for unsupported subsystem in RHEL. Our policy prevents it. If you decide to modify standard src.rpm, you have to manage all problems yourself.