Spec URL: http://sdz.fedorapeople.org/etherpad/jbcrypt.spec SRPM URL: http://sdz.fedorapeople.org/etherpad/jbcrypt-0.3-1.fc12.src.rpm Description: This package is needed for the effort of packaging Etherpad.
I will do the review. Before starting official review though, I have one question: Was it really your intention to package java file inside jar? I assume you meant to package .class file. Please fix this before we go any further (quick rpmlint was clean though)
You're obviously right! Fixing that right now. Sorry for that stupid thing and thanks for catching it! :)
I'll do this over the weekend, since I'm travelling right now and will have to get back to my other machine.
Heh, turns out that this was way easier than I expected it to be. Sorry for the delay. Here are the updated files: Spec URL: http://sdz.fedorapeople.org/rpmbuild/jbcrypt.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/jbcrypt-0.3-2.fc13.src.rpm
It's your review. You only delayed yourself :-) Package is nice and clean. APPROVED
Just for the record: rpmlint produced no warnings/errors.
New Package CVS Request ======================= Package Name: jbcrypt Short Description: Strong password hashing for Java Owners: sdz Branches: F-12 F-13
Thanks again for the quick review, this is awesome! :) (mhm, now I'm curious how far we get with etherpad)
Shouldn't this be named "jBCrypt" to match the case of the upstream project? Possibly you could run the TestBCrypt in %check section?
(In reply to comment #9) > Shouldn't this be named "jBCrypt" to match the case of the upstream project? > From packaging guidelines on naming: While case sensitivity is not a mandatory requirement, case should only be used where necessary. Keep in mind to respect the wishes of the upstream maintainers. If they refer to their application as "ORBit", you should use "ORBit" as the package name, and not "orbit". However, if they do not express any preference of case, you should default to lowercase naming. Upstream uses jBCrypt, but I am not sure how much they care about the case. Now that I think about it I am leaning more towards jBCrypt too, but I would leave it up to packager. > Possibly you could run the TestBCrypt in %check section? This is definitely a good idea, should have noticed too. Sebastian? I suppose you don't mind the naming that much...so one more release number with changed name and test run?
(In reply to comment #10) > Sebastian? I suppose you don't mind the naming that much...so one more release > number with changed name and test run? I can't exactly recall why I used lowercase-only letters in the first place, so yes, I'm more than alright with changing it. It's also compiling the test cases now. :) Spec URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/jBCrypt-0.3-3.fc13.src.rpm
New Package CVS Request ======================= Package Name: jBCrypt Short Description: Strong password hashing for Java Owners: sdz Branches: F-12 F-13
CVS done (by process-cvs-requests.py).
Built in Rawhide and being queued for updates soon. Thanks again!