Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-3.fc12.src.rpm Description: iec16022 is a program for producing ISO/IEC 16022 2D barcodes, also known as Data Matrix. These barcodes are defined in the ISO/IEC 16022 standard.
spot, do your comments about another Data Matrix related package in bug 561286 also apply to this one? Adding blocker on FE-legal until you've had a chance to take a look.
I continue to be unaware of any valid patents which would prevent this package from being included in Fedora. Lifting FE-Legal.
1) If no previous version of -libs is installed (for example in a clean mock build), the test suite throws errors but doesn't fail the build: make: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' make check-TESTS make[1]: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' /builddir/build/BUILD/iec16022-0.2.4/.libs/lt-iec16022: error while loading shared libraries: libiec16022.so.0: cannot open shared object file: No such file or directory [...] diff: testsuite-test.text: No such file or directory Text test FAILED diff: testsuite-test.eps: No such file or directory EPS test FAILED diff: testsuite-test.png: No such file or directory PNG test FAILED diff: testsuite-test.bin: No such file or directory Bin test FAILED diff: testsuite-test.hex: No such file or directory Hex test FAILED rm: cannot remove `testsuite-test.*': No such file or directory PASS: ./testsuite.sh ============= 1 test passed ============= Some LD_LIBRARY_PATH settings should be added to make the test suite do the right thing (use the just built libraries, this should be reported upstream), for example this at start of %check: export LD_LIBRARY_PATH=$RPM_BUILD_ROOT%{_libdir} And patching of upstream build process/test scripts is needed; if tests fail, the test suite and build should fail too. 2) (Cosmetic) --disable-dependency-tracking is the default nowadays, it can be dropped from %configure arguments. 3) Would not hurt to make the dependency on -libs in -devel arch qualified, ditto perhaps add one from main package to -libs: Requires: %{name}-libs%{?_isa} = %{version}-%{release} http://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires
Fixed now :) + make -C test check make: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' make check-TESTS make[1]: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test' Text test passed EPS test passed PNG test passed Bin test passed Hex test passed PASS: ./testsuite.sh ============= 1 test passed ============= Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-4.fc12.src.rpm
Created attachment 418918 [details] Fix test suite exit status on failure (In reply to comment #3) > And patching of upstream build process/test scripts is needed; if tests fail, > the test suite and build should fail too. Looks like this part is not addressed yet. Something like the attached patch should do the trick (I just sent the patch upstream too). Other remaining issues: %configure and the rpath seds should be done in %build, not %prep. Version in %changelog's entry for 0.2.4-4 is wrong (0.2.4-3).
Sorry missed that Here it is: Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-5.fc12.src.rpm
The rpath related sed commands need to be placed between %configure and make, otherwise they have no effect.
Fixed: Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-6.fc12.src.rpm
Looks good now, approved.
New Package CVS Request ======================= Package Name: viewnior Short Description: The Elegant Image Viewer Owners: taljurf Branches: F-11 F-13 rawhide InitialCC: taljurf
(In reply to comment #10) > New Package CVS Request > ======================= > Package Name: viewnior > Short Description: The Elegant Image Viewer > Owners: taljurf > Branches: F-11 F-13 rawhide > InitialCC: taljurf sorry by mistake New Package CVS Request ======================= Package Name: iec16022 Short Description: Generate ISO/IEC 16022 2D barcodes Owners: taljurf Branches: F-11 F-13 rawhide InitialCC: taljurf
With the release of F13 we no longer allow F11 branches. Also, why no F12 branch? Can you doublecheck and confirm your request?
(In reply to comment #12) > With the release of F13 we no longer allow F11 branches. > > Also, why no F12 branch? > > Can you doublecheck and confirm your request? Sorry, I misunderstood something. New Package CVS Request ======================= Package Name: iec16022 Short Description: Generate ISO/IEC 16022 2D barcodes Owners: taljurf Branches: F-12 F-13 InitialCC: taljurf
CVS done (by process-cvs-requests.py).
Tareq: ping?
I'm busy these days with my final exams. I'll do it as soon as i'm finished, on the 1st of July.
iec16022-0.2.4-6.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/iec16022-0.2.4-6.fc13
iec16022-0.2.4-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/iec16022-0.2.4-6.fc12
iec16022-0.2.4-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
iec16022-0.2.4-6.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
I need the iec16022 package for the EPEL branches; I'm going to maintain it there. If you would like to maintain it on the EPEL branches as well, we can re-assign it at any time to you, just let me simply know. Or you can become only a co-maintainer if you prefer that. However, I need the package :) Package Change Request ====================== Package Name: iec16022 New Branches: el4 el5 el6 Owners: robert
Git done (by process-git-requests).
iec16022-0.2.4-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el6
iec16022-0.2.4-7.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el5
iec16022-0.2.4-7.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el4
(In reply to comment #21) > I need the iec16022 package for the EPEL branches; I'm going to maintain it > there. If you would like to maintain it on the EPEL branches as well, we can > re-assign it at any time to you, just let me simply know. Or you can become > only a co-maintainer if you prefer that. However, I need the package :) > > > Package Change Request > ====================== > Package Name: iec16022 > New Branches: el4 el5 el6 > Owners: robert It would better for me if you maintain the EPEL branches yourself, since I'm busy these days. I'll continue to maintain the normal Fedora packages. Good Luck :)
iec16022-0.2.4-7.el4 has been pushed to the Fedora EPEL 4 stable repository.
iec16022-0.2.4-7.el6 has been pushed to the Fedora EPEL 6 stable repository.
iec16022-0.2.4-7.el5 has been pushed to the Fedora EPEL 5 stable repository.
Package Change Request ====================== Package Name: iec16022 New Branches: epel7 Owners: robert