Bug 594844 - Review Request: iec16022 - Generate ISO/IEC 16022 2D barcodes
Summary: Review Request: iec16022 - Generate ISO/IEC 16022 2D barcodes
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 12
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ville Skyttä
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-21 18:45 UTC by Tareq Al Jurf
Modified: 2014-10-13 23:02 UTC (History)
5 users (show)

Fixed In Version: iec16022-0.2.4-7.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-07-01 18:39:11 UTC
Type: ---
Embargoed:
ville.skytta: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)
Fix test suite exit status on failure (1.88 KB, patch)
2010-06-02 06:02 UTC, Ville Skyttä
no flags Details | Diff

Description Tareq Al Jurf 2010-05-21 18:45:20 UTC
Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec
SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-3.fc12.src.rpm
Description: iec16022 is a program for producing ISO/IEC 16022 2D barcodes, also
known as Data Matrix.  These barcodes are defined in the ISO/IEC 16022
standard.

Comment 1 Ville Skyttä 2010-05-24 15:47:22 UTC
spot, do your comments about another Data Matrix related package in bug 561286 also apply to this one?  Adding blocker on FE-legal until you've had a chance to take a look.

Comment 2 Tom "spot" Callaway 2010-05-24 16:10:30 UTC
I continue to be unaware of any valid patents which would prevent this package from being included in Fedora. Lifting FE-Legal.

Comment 3 Ville Skyttä 2010-05-24 18:37:10 UTC
1) If no previous version of -libs is installed (for example in a clean mock build), the test suite throws errors but doesn't fail the build:

make: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test'
make  check-TESTS
make[1]: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test'
/builddir/build/BUILD/iec16022-0.2.4/.libs/lt-iec16022: error while loading shared libraries: libiec16022.so.0: cannot open shared object file: No such file or directory
[...]
diff: testsuite-test.text: No such file or directory
Text test FAILED
diff: testsuite-test.eps: No such file or directory
EPS test FAILED
diff: testsuite-test.png: No such file or directory
PNG test FAILED
diff: testsuite-test.bin: No such file or directory
Bin test FAILED
diff: testsuite-test.hex: No such file or directory
Hex test FAILED
rm: cannot remove `testsuite-test.*': No such file or directory
PASS: ./testsuite.sh
=============
1 test passed
=============

Some LD_LIBRARY_PATH settings should be added to make the test suite do the right thing (use the just built libraries, this should be reported upstream), for example this at start of %check:
export LD_LIBRARY_PATH=$RPM_BUILD_ROOT%{_libdir}

And patching of upstream build process/test scripts is needed; if tests fail, the test suite and build should fail too.

2) (Cosmetic) --disable-dependency-tracking is the default nowadays, it can be dropped from %configure arguments.

3) Would not hurt to make the dependency on -libs in -devel arch qualified, ditto perhaps add one from main package to -libs:
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
http://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires

Comment 4 Tareq Al Jurf 2010-05-27 10:47:22 UTC
Fixed now :)

+ make -C test check
make: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test'
make  check-TESTS
make[1]: Entering directory `/builddir/build/BUILD/iec16022-0.2.4/test'
Text test passed
EPS test passed
PNG test passed
Bin test passed
Hex test passed
PASS: ./testsuite.sh
=============
1 test passed
=============

Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec
SRPM URL:
http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-4.fc12.src.rpm

Comment 5 Ville Skyttä 2010-06-02 06:02:22 UTC
Created attachment 418918 [details]
Fix test suite exit status on failure

(In reply to comment #3)
> And patching of upstream build process/test scripts is needed; if tests fail,
> the test suite and build should fail too.

Looks like this part is not addressed yet.  Something like the attached patch should do the trick (I just sent the patch upstream too).

Other remaining issues:

%configure and the rpath seds should be done in %build, not %prep.

Version in %changelog's entry for 0.2.4-4 is wrong (0.2.4-3).

Comment 7 Ville Skyttä 2010-06-02 15:00:48 UTC
The rpath related sed commands need to be placed between %configure and make, otherwise they have no effect.

Comment 9 Ville Skyttä 2010-06-02 17:01:17 UTC
Looks good now, approved.

Comment 10 Tareq Al Jurf 2010-06-02 18:18:24 UTC
New Package CVS Request
=======================
Package Name: viewnior
Short Description: The Elegant Image Viewer
Owners: taljurf
Branches: F-11 F-13 rawhide
InitialCC: taljurf

Comment 11 Tareq Al Jurf 2010-06-02 18:19:49 UTC
(In reply to comment #10)
> New Package CVS Request
> =======================
> Package Name: viewnior
> Short Description: The Elegant Image Viewer
> Owners: taljurf
> Branches: F-11 F-13 rawhide
> InitialCC: taljurf    

sorry by mistake

New Package CVS Request
=======================
Package Name: iec16022
Short Description: Generate ISO/IEC 16022 2D barcodes
Owners: taljurf
Branches: F-11 F-13 rawhide
InitialCC: taljurf

Comment 12 Kevin Fenzi 2010-06-03 20:29:01 UTC
With the release of F13 we no longer allow F11 branches. 

Also, why no F12 branch?

Can you doublecheck and confirm your request?

Comment 13 Tareq Al Jurf 2010-06-03 21:52:35 UTC
(In reply to comment #12)
> With the release of F13 we no longer allow F11 branches. 
> 
> Also, why no F12 branch?
> 
> Can you doublecheck and confirm your request?    

Sorry, I misunderstood something.

New Package CVS Request
=======================
Package Name: iec16022
Short Description: Generate ISO/IEC 16022 2D barcodes
Owners: taljurf
Branches: F-12 F-13
InitialCC: taljurf

Comment 14 Kevin Fenzi 2010-06-07 20:58:39 UTC
CVS done (by process-cvs-requests.py).

Comment 15 Ville Skyttä 2010-06-13 21:06:42 UTC
Tareq: ping?

Comment 16 Tareq Al Jurf 2010-06-14 19:22:59 UTC
I'm busy these days with my final exams.
I'll do it as soon as i'm finished, on the 1st of July.

Comment 17 Fedora Update System 2010-07-01 08:25:22 UTC
iec16022-0.2.4-6.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/iec16022-0.2.4-6.fc13

Comment 18 Fedora Update System 2010-07-01 08:53:38 UTC
iec16022-0.2.4-6.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/iec16022-0.2.4-6.fc12

Comment 19 Fedora Update System 2010-07-01 18:39:05 UTC
iec16022-0.2.4-6.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2010-07-01 18:55:47 UTC
iec16022-0.2.4-6.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Robert Scheck 2011-10-26 09:01:20 UTC
I need the iec16022 package for the EPEL branches; I'm going to maintain it
there. If you would like to maintain it on the EPEL branches as well, we can
re-assign it at any time to you, just let me simply know. Or you can become
only a co-maintainer if you prefer that. However, I need the package :)


Package Change Request
======================
Package Name: iec16022
New Branches: el4 el5 el6
Owners: robert

Comment 22 Gwyn Ciesla 2011-10-26 11:49:18 UTC
Git done (by process-git-requests).

Comment 23 Fedora Update System 2011-10-26 12:46:24 UTC
iec16022-0.2.4-7.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el6

Comment 24 Fedora Update System 2011-10-26 12:52:14 UTC
iec16022-0.2.4-7.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el5

Comment 25 Fedora Update System 2011-10-26 12:52:25 UTC
iec16022-0.2.4-7.el4 has been submitted as an update for Fedora EPEL 4.
https://admin.fedoraproject.org/updates/iec16022-0.2.4-7.el4

Comment 26 Tareq Al Jurf 2011-10-27 10:38:11 UTC
(In reply to comment #21)
> I need the iec16022 package for the EPEL branches; I'm going to maintain it
> there. If you would like to maintain it on the EPEL branches as well, we can
> re-assign it at any time to you, just let me simply know. Or you can become
> only a co-maintainer if you prefer that. However, I need the package :)
> 
> 
> Package Change Request
> ======================
> Package Name: iec16022
> New Branches: el4 el5 el6
> Owners: robert

It would better for me if you maintain the EPEL branches yourself, since I'm busy these days. I'll continue to maintain the normal Fedora packages.
Good Luck :)

Comment 27 Fedora Update System 2011-11-20 20:18:32 UTC
iec16022-0.2.4-7.el4 has been pushed to the Fedora EPEL 4 stable repository.

Comment 28 Fedora Update System 2011-11-20 20:18:42 UTC
iec16022-0.2.4-7.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 29 Fedora Update System 2011-11-20 20:19:22 UTC
iec16022-0.2.4-7.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 30 Robert Scheck 2014-10-11 21:42:00 UTC
Package Change Request
======================
Package Name: iec16022
New Branches: epel7
Owners: robert

Comment 31 Kevin Fenzi 2014-10-13 23:02:18 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.