Hide Forgot
Description of problem: Currently, if a target sends multiple back-to-back LOGO's, we try to process all of them irrespective of the status of processing of prior LOGOs, which results in an oops in fc_rport_work() in libfc - [<ffffffff810a12e1>] ? trace_hardirqs_off+0x9/0x20 [<ffffffffa031a86c>] ? fc_rport_work+0x0/0x3d4 [libfc] [<ffffffff81056d14>] worker_thread+0x149/0x1e5 [<ffffffff81059c27>] ? autoremove_wake_function+0x0/0x3d [<ffffffff81056bcb>] ? worker_thread+0x0/0x1e5 [<ffffffff810598da>] kthread+0x6e/0x76 [<ffffffff81003a14>] kernel_thread_helper+0x4/0x10 [<ffffffff814a4369>] ? restore_args+0x0/0x30 [<ffffffff8105986c>] ? kthread+0x0/0x76 [<ffffffff81003a10>] ? kernel_thread_helper+0x0/0x10 Version-Release number of selected component (if applicable): How reproducible: Rapid fc uplink flaps on a ucs 6120 at 2 second intervals causes this issue to be run into after a few hours. Steps to Reproduce: 1. 2. 3. Actual results: Initiator node panics with above stack trace. Expected results: All I/Os run normally and node does not panic. Additional info: The patch to this bug is being tested, and an earlier patch has been submitted to the upstream kernel. A latest patch with minor changes will be resubmitted upstream and the patch will be attached to this bug as well.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion.
The fix to this bug has been submitted upstream in three separate patches to libfc. Attaching the RHEL diffs. The upstream patches have not yet been merged into the openfcoe-next git tree. Will update this bug with links to the openfcoe-next commit links when Robert Love merges the fixes.
Created attachment 421913 [details] libfc patch 1 of 3 First patch. Two more follow.
Created attachment 421914 [details] libfc patch 2 of 3 libfc patch 2. 1 more follows.
Created attachment 421915 [details] libfc patch 3 of 3 libfc patch 3.
These patches need to be included in the 5.5-z stream as well.
The patches have been committed to the open-fcoe-next git tree at - http://www.open-fcoe.org/wordpress/frame.php?url=http://www.open-fcoe.org/openfc/gitweb/ The commit numbers of these patches are - 36f7ed3655d8f88a10c3142a3763766e3de3b460 libfc: fix indefinite rport restart b51c2fa951b3ccd117d523dc15ec28ff1402f2e2 libfc: Fix remote port restart problem The patches merge changes among the 3 diffs attached. Hence, please refer to these upstream diffs.
This issue has been proposed when we are only considering blocker issues in the current Red Hat Enterprise Linux release. It has been denied for the current Red Hat Enterprise Linux release. ** If you would still like this issue considered for the current release, ask your support representative to file as a blocker on your behalf. Otherwise ask that it be considered for the next Red Hat Enterprise Linux release. **
This is the first I've seen/heard of this. Cisco states this is a blocker since these patches fix crashes. Just received this info.
36f7ed3655d8f88a10c3142a3763766e3de3b460 libfc: fix indefinite rport restart b51c2fa951b3ccd117d523dc15ec28ff1402f2e2 libfc: Fix remote port restart problem We have these fixes merged. They are in snap8.
(In reply to comment #11) > We have these fixes merged. They are in snap8. Actually, I am not sure if it is snap 8. The bugzilla is here https://bugzilla.redhat.com/show_bug.cgi?id=603263 The kernel it got merged in is kernel-2.6.32-42.el6
I'm going to dupe this to bug 603263 and request access to that. *** This bug has been marked as a duplicate of bug 603263 ***
Bug 603263 should now be accessible by Cisco. Add yourselves as you see fit.