Bug 595749 - Review Request: apache-commons-jxpath - rename of jakarta-commons-jxpath
Summary: Review Request: apache-commons-jxpath - rename of jakarta-commons-jxpath
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
Depends On: 594756
Blocks: JakartaCommonsRename
TreeView+ depends on / blocked
Reported: 2010-05-25 14:22 UTC by Stanislav Ochotnicky
Modified: 2010-05-28 08:13 UTC (History)
3 users (show)

Clone Of:
Last Closed: 2010-05-28 08:13:17 UTC
akurtako: fedora-review+
dennis: fedora-cvs+

Attachments (Terms of Use)

Description Stanislav Ochotnicky 2010-05-25 14:22:15 UTC
Spec URL: http://sochotni.fedorapeople.org/apache-commons-jxpath.spec
SRPM URL: http://sochotni.fedorapeople.org/apache-commons-jxpath-1.3-1.fc12.src.rpm

Defines a simple interpreter of an expression language called XPath.
JXPath applies XPath expressions to graphs of objects of all kinds:
JavaBeans, Maps, Servlet contexts, DOM etc, including mixtures thereof.

Please note that this is a re-review of existing package!

Comment 1 Alexander Kurtakov 2010-05-25 15:07:02 UTC
I'll take this one.
I'm making it depends on apache-commons-beanutils review

Comment 2 Alexander Kurtakov 2010-05-25 15:21:31 UTC

OK: rpmlint must be run on every package. Output:
apache-commons-jxpath.noarch: W: non-conffile-in-etc /etc/maven/fragments/apache-commons-jxpath
Not a problem. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
NOTOK: Packages must not own files or directories already owned by other packages. 
%{_mavendepmapfragdir} should not be owned

OK: All filenames in rpm packages must be valid UTF-8. 
OK: I'm aware this is a rename and obsoletes/provides are good.

Comment 3 Stanislav Ochotnicky 2010-05-25 15:38:42 UTC
Fixed owner of directories

Spec URL: http://sochotni.fedorapeople.org/apache-commons-jxpath.spec

Comment 4 Alexander Kurtakov 2010-05-25 15:40:49 UTC
Looks good, thanks.

This package is APPROVED.

Comment 5 Stanislav Ochotnicky 2010-05-25 15:44:39 UTC
Thanks for review. Requesting CVS

New Package CVS Request
Package Name: apache-commons-jxpath
Short Description: Simple XPath interpreter
Owners: sochotni fnasser

Comment 6 Dennis Gilmore 2010-05-25 20:54:42 UTC
CVS Done

Comment 7 Alexander Kurtakov 2010-05-28 08:13:17 UTC
Build in koji.

Note You need to log in before you can comment on or make changes to this bug.