Created attachment 416589 [details]
patch to make mkdumprd default to the currently booted filesystem
Description of problem:
When system-config-kdump (and possibly firstboot as well) configures kdump it does not specify the target filesystem in /etc/kdump.conf. This might be considered a bug in system-config-kdump itself however it would be more logical for mkdumprd to use the currently booted filesystem as the default.
This can cause rather painful issues for customers on large memory systems. This is because currently if mkdumprd does not see a target filesystem it completely ignores the core_collector line in the config which means no pages are filtered out. This can cause dump times of several hours and also shows no progress on the console making it impossible to know if it is hung or just very slow.
I am attaching a patch which both cleans up some of mkdumprd and also adds some code to handle a kdump.conf that does not have a target specified.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. use system-config-kdump to configure kdump
2. force a crash
3. note that no progress is shown when dumping and also makedumpfile is not used (therefore any pages set to be filtered out is ignored).
the core_collector argument (i.e. makedumpfile) should not be ignored
I'm fine with the patch functionality, but please return the fs checks as they were. The check as you have it will allow a fat/msdos filesystem to be used, and thoes dont support our naming conventions or common vmcore file size ranges
also, it seems the removal of all the option parsing around line 2120 will wind up breaking mkdumprd entirely, as those options will fall to the default case and cause a file system mount failure.
(In reply to comment #2)
> I'm fine with the patch functionality, but please return the fs checks as they
> were. The check as you have it will allow a fat/msdos filesystem to be used,
> and thoes dont support our naming conventions or common vmcore file size ranges
Good catch. I found that bit in the code already in another spot and thought it was a good idea but I think in the spot it was in before this wasn't an issue.
(In reply to comment #3)
> also, it seems the removal of all the option parsing around line 2120 will wind
> up breaking mkdumprd entirely, as those options will fall to the default case
> and cause a file system mount failure.
This is not the case. In the original version it would parse the kdump.conf twice. I added a small bit of code to get all the information it needs on that first pass. This was needed so that I could add the code that determined the default filesystem info to dump to without just loosing that when the file got parsed again. Note that the code you are looking at is now no longer in a loop that is reading the config file but is now just a case statement which is determining the operation based on the USING_METHOD variable.
Created attachment 416852 [details]
updated patch that replaces the fs check code
Our GUI tools should probably work in GA, reflagging for 6.0.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release. Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release. This request is not yet committed for
Verified with -133.el6:
[root@hp-xw4200-01 ~]# yum list kexec-tools
Loaded plugins: rhnplugin
This system is not registered with RHN.
RHN support will be disabled.
kexec-tools.x86_64 2.0.0-133.el6 @anaconda-RedHatEnterpriseLinux-201008071453.x86_64/6.0
[root@hp-xw4200-01 ~]# cat /etc/kdump.conf
path /var/crash <=====Created by system-config-kdump
core_collector makedumpfile -d 31 -c <=====Created by system-config-kdump
[root@hp-xw4200-01 ~]# echo c > /proc/sysrq-trigger
[root@hp-xw4200-01 ~]# ls -l /var/crash/127.0.0.1-2010-08-10-05\:01\:25/vmcore
-rw-------. 1 root root 20967973 Aug 10 05:01 /var/crash/127.0.0.1-2010-08-10-05:01:25/vmcore
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.