Spec URL: http://kaio.fedorapeople.org/pkgs/ibus-table-chinese.spec SRPM URL: http://kaio.fedorapeople.org/pkgs/ibus-table-chinese-1.3.0.20100527-1.fc13.src.rpm Description: Chinese tables for IBus-Table
*** Bug 579635 has been marked as a duplicate of this bug. ***
*** Bug 579613 has been marked as a duplicate of this bug. ***
Would it be better to subpackage some of the tables?
Spec URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-chinese.spec SRPM URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-chinese-1.3.0.20101126-1.el6.src.rpm
+ Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2633878 is successful. + rpmlint is output for SRPM and for RPM. ibus-table-chinese.src: I: enchant-dictionary-not-found zh_CN ibus-table-chinese.src: I: enchant-dictionary-not-found zh_TW ibus-table-chinese.src:339: W: macro-in-comment %doc ibus-table-chinese.src: W: invalid-url Source0: http://ibus.googlecode.com/files/ibus-table-chinese-1.3.0.20101126-Source.tar.gz HTTP Error 404: Not Found ibus-table-chinese.spec:339: W: macro-in-comment %doc ibus-table-chinese.spec: W: invalid-url Source0: http://ibus.googlecode.com/files/ibus-table-chinese-1.3.0.20101126-Source.tar.gz HTTP Error 404: Not Found 1 packages and 1 specfiles checked; 0 errors, 4 warnings. + source files match upstream url (sha1sum) f92a8dd02cf94df9b81172b1763162d2e3ae6c25 ibus-table-chinese-1.3.0.20101126-Source.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + Macro use appears rather consistent. + no duplicates in %files. + file permissions are appropriate. Note: there are two minor issues just mentioned here. 1. ibus-table-chinese-all sub package to pull all ibus tables has no files, so it is not generated at all. maybe it can be generated later. 2. there is a warning when doing rpm -V ibus-table-chinese-* # rpm -V ibus-table-chinese-wu ..5....T. /usr/share/ibus-table/tables/wu.db After discussed with Ding-Yi Chen, this need some upstream fixes, so will be considered later. APPROVED.
New Package SCM Request ======================= Package Name: ibus-table-chinese Short Description: Chinese tables for IBus-Table Owners: dchen Branches: f13 f14 el6 InitialCC:
I don't think ibus-table-chinese-all subpackage is necessary or useful, maybe it'll be better to remove this meta-package. Debian and ibus-table-others don't include a such subpackage.
I support this. ibus-table-chinese as metapackage with ibus-table-* as subpackage is the best way I reckon. The reason for this is to minimize time of package maintenance. As there are more than 20 tables it is a disaster for the maintainer to keep them each in separated repository, except if they are all owned by someone who is not doing this as their work responsibilities. I am already the victim of that "packaging time-sucking disaster", sincerely I don't want Ding-Yi to suffer from the same consequence.
This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag.
Caius, Thanks, but even with ibus-table-chinese-all, I still need to maintain those tables as sub-packages. As Jens Petersen pointed out, we can use yum install "ibus-table-chinese-*" to install all chinese table in one go.
Peng, You need click on "take" on the right of "Nobody's working on this, feel free to take it" to make your review to be recognized.
In case you are interested, I've released a new version, which removed ibus-table-chinese-all, and support out-of-source cmake build. Spec URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-chinese.spec SRPM URL: http://dchen.fedorapeople.org/files/rpms/ibus-table-chinese-1.3.0.20101201-1.el6.src.rpm
I misunderstood. I also dislike -all.
(In reply to comment #11) > Peng, > > You need click on "take" on the right of > "Nobody's working on this, feel free to take it" > to make your review to be recognized. OK. I took it.
Git done (by process-git-requests).
ibus-table-chinese-1.3.0.20101206-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.3.0.20101206-1.fc14
ibus-table-chinese-1.3.0.20101206-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.3.0.20101206-1.fc13
ibus-table-chinese-1.3.0.20101206-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update ibus-table-chinese'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ibus-table-chinese-1.3.0.20101206-1.fc14
ibus-table-chinese-1.3.0.20101206-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
ibus-table-chinese-1.3.0.20101206-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.