Bug 597118 - A warning should be given in the help of mke2journal-L for the length of label
Summary: A warning should be given in the help of mke2journal-L for the length of label
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
: 597116 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-28 07:24 UTC by Yufang Zhang
Modified: 2011-07-14 19:11 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2011-07-14 19:11:47 UTC
Embargoed:


Attachments (Terms of Use)

Description Yufang Zhang 2010-05-28 07:24:50 UTC
Description of problem:
For the mke2journal-L, label is limited to 16 bytes. So if you set label longer than that length, it will be truncated. Thus the label set may not be as what you expect. So it is better to add some warning in the help of mke2journal-L to let people know this limitation. 

Version-Release number of selected component (if applicable):
major: 1
minor: 2
release: 7
extra: 


How reproducible:
Always

Steps to Reproduce:
1.><fs> mke2journal-L 1024 "1234567890abcdefg" /dev/VG/jounal
  
2.><fs> get-e2label /dev/VG/jounal
1234567890abcdef

  
Actual results:


Expected results:
At least a warning should be given in the help to inform people this limitation.

Additional info:

Comment 1 Yufang Zhang 2010-05-28 08:51:38 UTC
*** Bug 597116 has been marked as a duplicate of this bug. ***

Comment 2 Richard W.M. Jones 2010-06-01 14:41:56 UTC
Confirmed from the Linux sources that the volume name is
limited to 16 bytes, even for ext4.

Comment 3 Richard W.M. Jones 2010-06-01 14:44:56 UTC
Confirmed also that Linux swap labels are 16 bytes long.

Comment 4 Richard W.M. Jones 2010-06-01 15:21:45 UTC
Patch posted upstream:
https://www.redhat.com/archives/libguestfs/2010-June/msg00011.html

Comment 5 Fedora Update System 2010-06-02 21:12:32 UTC
libguestfs-1.2.9-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.el5

Comment 6 Fedora Update System 2010-06-02 21:26:19 UTC
libguestfs-1.2.9-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.fc13

Comment 7 Richard W.M. Jones 2010-06-02 21:32:59 UTC
This patch has been pushed upstream.

If this needs to be fixed for RHEL 5 / 6, please clone
this bug and adjust the Product accordingly.

Comment 8 Fedora Update System 2010-06-03 08:49:01 UTC
libguestfs-1.2.9-1.el5.1 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.el5.1


Note You need to log in before you can comment on or make changes to this bug.