This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 597145 - guestfish 'help' command should indicate error in exit status with an unknown command
guestfish 'help' command should indicate error in exit status with an unknown...
Status: CLOSED UPSTREAM
Product: Virtualization Tools
Classification: Community
Component: libguestfs (Show other bugs)
unspecified
All Linux
low Severity low
: ---
: ---
Assigned To: Richard W.M. Jones
:
Depends On:
Blocks: 598771 598772
  Show dependency treegraph
 
Reported: 2010-05-28 04:54 EDT by Jinxin Zheng
Modified: 2011-07-14 15:12 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 598771 598772 (view as bug list)
Environment:
Last Closed: 2011-07-14 15:12:24 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Jinxin Zheng 2010-05-28 04:54:40 EDT
Description of problem:
Issueing the 'help' command in guestfish with an unknown command name exits 
with a 0 exit code.

Version-Release number of selected component (if applicable):
guestfish 1.3.17

How reproducible:
Always

Steps to Reproduce:
1. guestfish help foo
2. echo $?
3.
  
Actual results:
the exit status of guestfish is 0

Expected results:
supposed to be some other than 0 to indicate an error.

Additional info:
I wanted to use help to test the availability of some new commands in a script, 
finding that it's impossible to determine only from the exit status of guestfish.
Therefore I must test the stderr in order to work the result out.
Comment 1 Richard W.M. Jones 2010-06-01 11:31:26 EDT
Patch posted upstream:
https://www.redhat.com/archives/libguestfs/2010-June/msg00013.html

Please clone this bug if you want this in RHEL 5/6.  It's a relatively
simple change to backport.
Comment 2 Jinxin Zheng 2010-06-01 22:18:46 EDT
(In reply to comment #1)
> Patch posted upstream:
> https://www.redhat.com/archives/libguestfs/2010-June/msg00013.html
> 
> Please clone this bug if you want this in RHEL 5/6.  It's a relatively
> simple change to backport.    

Cloned as #598771 and #598772 since this is a simple change.
Comment 3 Fedora Update System 2010-06-02 17:12:24 EDT
libguestfs-1.2.9-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.el5
Comment 4 Fedora Update System 2010-06-02 17:26:10 EDT
libguestfs-1.2.9-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.fc13
Comment 5 Fedora Update System 2010-06-03 04:48:49 EDT
libguestfs-1.2.9-1.el5.1 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libguestfs-1.2.9-1.el5.1

Note You need to log in before you can comment on or make changes to this bug.