Spec URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw-1.2.4.1-1.fc13.src.rpm Description: Hacked up version of ncurses gem that supports wide characters and ruby1.9.1. Original ncurses gem by t-peters.de. Spec and SRPM built using gem2rpm utility.
rpmlint output is : rubygem-ncursesw.i686: W: no-soname /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/lib/ncursesw_bin.so rubygem-ncursesw.i686: W: unstripped-binary-or-object /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/ncursesw_bin.so rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/form_wrap.c rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/Destroy_checker/destroyed%3f-i.yaml %3f rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/menu_wrap.h rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/Menu/MENU/user_object%3d-i.yaml %3d rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/menu_wrap.c rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/panel_wrap.c rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/Form/FORM/user_object%3d-i.yaml %3d rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/ncurses_wrap.c rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/form_wrap.h rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/ncurses_wrap.h rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/Menu/ITEM/user_object%3d-i.yaml %3d rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/Form/FIELD/user_object%3d-i.yaml %3d rubygem-ncursesw.i686: W: unexpanded-macro /usr/lib/ruby/gems/1.8/doc/ncursesw-1.2.4.1/ri/Ncurses/WINDOW/respond_to%3f-i.yaml %3f rubygem-ncursesw.i686: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/panel_wrap.h --- 1. Do I split the the files into a devel subpackage? 2. How do i solve the 'unstripped-binary-or-object' problem? --- koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2217882
Updated spec and srpm, replaced %define with %global
Some notes: Please also address the issue I wrote on bug 598138. Then: * Summary - Is "and ruby 1.9.1" part needed for Summary? (even if we move to ruby 1.9.x on F-14, I don't think this part is needed). * License - The license tag for this package should be "LGPLv2+". * Unneeded files - *.c, *.h files are for source files for C extension .so file, *.o binary files are used for generating the file. Also "extconf.rb" is like configure, and "mkmf.log" is like config.log. These files are not needed on runtime and should not be packaged into binary rpm. * Arch dependent binary file - C extension .so file is arch-dependent and must be moved to under %ruby_sitearch https://fedoraproject.org/wiki/Packaging/Ruby#Build_Architecture_and_File_Placement
UPDATED: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw-1.2.4.1-2.fc13.src.rpm Notes/doubts: ------ * Removed 'and ruby 1.9.1' from the summary. * rm -f all .c .o and .h files as I was not sure whether to %exclude it or not. * There are two .so files, one inside and one outside the lib directory. Put the lib one inside ruby_sitearch and removed the other one. * Added examples as a part of the -docs subpackage. Is that the right thing to do? Koji scratch build: ------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2222741
For -2: * For - Directory ownership of %geminstdir, %gemdir/doc, and "Changes THANKS TODO VERSION", please my comments on bug 598138. * Examples - For example, ------------------------------------------------------- $ ruby -rubygems ./examples/tclock.rb /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require': no such file to load -- ncurses (LoadError) from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require' from ./examples/tclock.rb:33 ------------------------------------------------------- Actually these example files (in -doc subpackage) all has 'require ncurses(.rb)', however actually the installed ruby script (in main package) is "ncursesw.rb". So these example files should be modified as such (I am not sure if we can create symlink as "ncurses.rb -> ncursesw.rb", because there is another "ncurses-0.9.1.gem" actually - although ncurses.gem seems the older version of ncursesw.gem)
UPDATED: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw-1.2.4.1-3.fc13.src.rpm Notes: ------ I ran sed and replaced all require 'ncurses' to require 'ncursesw'. HTH
(removing NEEDSPONSOR)
Koji Scratch build: -------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=2227505
2 issues * rpmlint issue for -debuginfo rpm related -------------------------------------------------------------- rubygem-ncursesw-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/rubygem-ncursesw-1.2.4.1/usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/ncurses_wrap.c rubygem-ncursesw-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/rubygem-ncursesw-1.2.4.1/usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/panel_wrap.h -------------------------------------------------------------- - To avoid this rpmlint complaint, please add below at the end of %build: -------------------------------------------------------------- pushd ./%{geminstdir} chmod 0644 *.h *.c popd -------------------------------------------------------------- * License - Please change the license tag on -doc subpacakge to "LGPLv2+ and LDPL" ref: http://lists.fedoraproject.org/pipermail/legal/2010-June/001290.html Please fix the above issue when importing this package into Fedora CVS. -------------------------------------------------------------- This package (rubygem-ncursesw) is APPROVED by mtasaka --------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-ncursesw Short Description: Hacked up version of ncurses gem Owners: shreyankg Branches: F-13
UPDATED: -------- Spec URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw.spec SRPM URL: http://shreyankg.fedorapeople.org/packaging/ncursesw/rubygem-ncursesw-1.2.4.1-4.fc13.src.rpm Notes: ------ rpmlint gives the following warning on the -doc rpm: W: invalid-license LDPL So I filed bug #600317 with rpmlint to correct it.
Please set fedora-cvs flag to ?.
(In reply to comment #12) > Please set fedora-cvs flag to ?. I'm sorry! :-)
Ah... sorry, wait. I just noticed that Fedora already includes ruby-ncurses and the upstream of both ruby-ncurses and rubygem-ncursesw is the same. Would you first contact ruby-ncurses's maintainer to discuss which should be kept in Fedora distrubution?
ref: https://admin.fedoraproject.org/pkgdb/acls/name/ruby-ncurses maintainer: slukasik _at_ redhat.com
(In reply to comment #14) > Ah... sorry, wait. > > I just noticed that Fedora already includes ruby-ncurses and > the upstream of both ruby-ncurses and rubygem-ncursesw is the same. The point of filing a rewiew request for rubygem-ncursesw is that it is one of the dependencies for sup 0.10.2 (http://rubyforge.org/projects/sup/), which I want to package for Fedora, but cannot do so until all its dependencies are in Fedora. The thing is the latest development version of sup (0.11) uses ruby-ncurses, but that is quite unstable. Since rubygem-ncursesw is required for sup-0.10.2 I would like it packaged temporarily, and I would obsolete this package once I package sup-0.11
Well, if currently you are only considering of importing packages which sup depends on, and under the current condition that ruby-ncurses is already in Fedora, then this package is not needed even for 0.10.2 (as far I checked the source code) For example sup-0.10.2/bin/sup contains: ------------------------------------------------------- 5 no_ncursesw = false 6 begin 7 require 'ncursesw' 8 rescue LoadError 9 require 'ncurses' 10 no_ncursesw = true 11 end ------------------------------------------------------- so sup falls back to using ncurses if ncursesw is not found. So if you are not interested in maintaining ncursesw once sup 0.11 is released, currently I am against importing this package into Fedora.
(In reply to comment #17) [..] > So if you are not interested in maintaining ncursesw once > sup 0.11 is released, currently I am against importing this > package into Fedora. Alright then, I guess we can close this request unless required later.
Okay, once closing as I think even sup-0.10.2 does not require ncursesw (provided that ruby-ncurses is available). If it is found that this package is needed, please reopen this bug (or file a new review request).
I filed a fresh review request for rubygem-ncursesw: bug 1266723. It's still maintained by the sup developers and is needed for proper unicode support in sup.