Red Hat Bugzilla – Bug 597888
Review Request: spek - free acoustic spectrum analyzer
Last modified: 2013-10-19 10:42:52 EDT
Hi, This is my first package, so I need a sponsor and a review. Thanks Spec URL: http://dl.dropbox.com/u/6598054/spek.spec SRPM URL: http://dl.dropbox.com/u/6598054/spek-0.4-1.fc13.src.rpm Description: Spek helps to analyze your audio files by showing their spectrogram. Spectrograms are used to analyze the quality of audio files, you can easily detect lossy re-encodes, web-rips and other badness by just looking at the spectrogram. Spek uses GStreamer to read audio files which means it supports most file formats you can think of. ScratchBuild : http://koji.fedoraproject.org/koji/taskinfo?taskID=2218397
Hi, As I've been told, this package is pretty useless without dependencies on gstreamer-plugin-base and good packages. So here are the new versions. Spec URL: http://dl.dropbox.com/u/6598054/spek.spec SRPM URL: http://dl.dropbox.com/u/6598054/spek-0.4-2.fc13.src.rpm ScratchBuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=2222419
Looks sane on a quick look and builds fine on koji.
In the meantime Spek 0.5 has been released: http://spek.googlecode.com/files/spek-0.5.tar.bz2
Christophe, did you perform some unofficial reviews?
> Requires: gtk2 >= 2.14 > Requires: gstreamer >= 0.10.17 > Requires: gstreamer-plugins-base >= 0.10.17 > Requires: gstreamer-plugins-good >= 0.10.17 Be aware of the following guideline: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Dependency on gtk2 and gstreamer library SONAMEs is automatic already. The explicit versions are much lower than what is available with Fedora. And gstreamer-plugins-good requires gstreamer-plugins-base. So, you should reduce these explicit Requires to just gstreamer-plugins-good with a comment that this app strictly needs this collection of plugins. > %install > rm -rf %{buildroot} > %clean > rm -rf %{buildroot} Since you also omitted the BuildRoot definition, you could drop further stuff: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
Just FYI, Spek 0.6 no longer depends on GStreamer, it now uses FFmpeg libraries: http://gitorious.org/spek/spek/blobs/master/NEWS#line49
Which means it's a candidate for RPMFusion, not Fedora. Might as well close this review... I'd like to see this land in RPMFusion, though.
> I'd like to see this land in RPMFusion, though. See https://bugzilla.rpmfusion.org/show_bug.cgi?id=1718