Bug 598261 - Link in about window does not work
Summary: Link in about window does not work
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-packagekit
Version: 13
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-31 23:02 UTC by Felix Möller
Modified: 2021-04-25 20:36 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-05-30 19:15:46 UTC
Type: ---
Embargoed:
mail: needinfo-


Attachments (Terms of Use)
info dialog (17.97 KB, image/png)
2010-05-31 23:02 UTC, Felix Möller
no flags Details

Description Felix Möller 2010-05-31 23:02:35 UTC
Created attachment 418412 [details]
info dialog

I did a rightclick on the icon in the taskbar telling me I have to relogin. I had to realize the link does not work. 

It says:
"Internal Error"
"URL resolution failed"

[fm@thinkpad ~]$ rpm -qf /usr/bin/gpk-update-viewer
gnome-packagekit-2.30.2-1.fc13.i686

Comment 1 Felix Möller 2010-06-22 06:59:44 UTC
this bug is still valid.

Comment 2 Richard Hughes 2010-06-22 15:01:18 UTC
Should be a simple patch if you want to give it a go.

Comment 3 Felix Möller 2010-06-22 16:20:32 UTC
Ok, so far I found that it is at:
git://git.gnome.org/gnome-packagekit

and the relvant file seems to be:
src/gpk-application.c arround line 2846:

        gtk_show_about_dialog (GTK_WINDOW (main_window),
                               "version", PACKAGE_VERSION,
                               "copyright", "Copyright \xc2\xa9 2007-2009 Richard Hughes",
                               "license", license_trans,
                               "wrap-license", TRUE,
                               "website-label", _("PackageKit Website"),
                               "website", "http://www.packagekit.org",
                                /* TRANSLATORS: description of application, gpk-application that is */
                               "comments", _("Package Manager for GNOME"),
                               "authors", authors,
                               "documenters", documenters,
                               "artists", artists,
                               "translator-credits", translators,
                               "logo-icon-name", GPK_ICON_SOFTWARE_INSTALLER,
                               NULL);

Sadly there the url seems to be valid ... :-(

Comment 4 Richard Hughes 2010-06-23 08:10:00 UTC
(In reply to comment #3)
> Sadly there the url seems to be valid ... :-(    

Close. This was the actual fix:

commit 10ce377a4aa8df19b6efed95200e25dfffaa3015
Author: Richard Hughes <richard>
Date:   Wed Jun 23 09:08:27 2010 +0100

    Use the correct URL in the about dialog to fix an error. Fixes rh#598261

diff --git a/src/gpk-watch.c b/src/gpk-watch.c
index f046482..79f42e8 100644
--- a/src/gpk-watch.c
+++ b/src/gpk-watch.c
@@ -480,7 +480,7 @@ gpk_watch_show_about_cb (GtkMenuItem *item, gpointer data)
                               "license", license_trans,
                               "wrap-license", TRUE,    
                               "website-label", _("PackageKit Website"),
-                              "website", "www.packagekit.org",
+                              "website", "http://www.packagekit.org",
                               "comments", "PackageKit",
                               "authors", authors,
                               "documenters", documenters,

Thanks for reporting this bug, and I hope you'll read some of the source now and help find other bugs. :-) Good luck!

Comment 5 Felix Möller 2011-05-30 15:20:11 UTC
this can be closed afaik.

Comment 6 Bug Zapper 2011-06-02 12:34:26 UTC
This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.