Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100603-1.fc13.src.rpm Description: Input Pad send characters to GUI clients
Any sponsors? http://koji.fedoraproject.org/koji/taskinfo?taskID=2234433
Hi fujiwara, You are already a member of packager group. So no need to set FE-NEEDSPONSOR. Only new contributors who have no access to packager cvs group need to set it.
Thanks for your comment.
I think this package needs versioned .so and install .so in -devel.
Added .so version info. http://github.com/fujiwarat/input-pad/commit/791ba5f3d22323e525a4153c7b0da272e9bba951 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100608-1.fc13.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=2237331
Thanks for the update. Can you fix following rpmlint messages? input-pad.x86_64: E: library-without-ldconfig-postin /usr/lib64/libinput-pad.so.0.0.1 input-pad.x86_64: E: library-without-ldconfig-postun /usr/lib64/libinput-pad.so.0.0.1 input-pad-python.x86_64: W: summary-not-capitalized C input-pad for python input-pad-xtest.x86_64: W: summary-not-capitalized C input-pad with XTEST extension other messages looks ok input-pad.x86_64: E: explicit-lib-dependency libX11 input-pad.x86_64: E: explicit-lib-dependency libxkbfile input-pad.x86_64: W: invalid-url URL: http://code.google.com/p/input-pad/ HTTP Error 404: Not Found input-pad.x86_64: W: shared-lib-calls-exit /usr/lib64/libinput-pad.so.0.0.1 exit.5 input-pad.x86_64: W: no-manual-page-for-binary input-pad input-pad-devel.x86_64: W: invalid-url URL: http://code.google.com/p/input-pad/ HTTP Error 404: Not Found input-pad-devel.x86_64: W: no-documentation input-pad-python.x86_64: W: invalid-url URL: http://code.google.com/p/input-pad/ HTTP Error 404: Not Found input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad.so _input_pad.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_window_gtk.so _input_pad_window_gtk.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_group.so _input_pad_group.so()(64bit) input-pad-python.x86_64: W: no-documentation input-pad-xtest.x86_64: E: explicit-lib-dependency libXtst input-pad-xtest.x86_64: W: invalid-url URL: http://code.google.com/p/input-pad/ HTTP Error 404: Not Found input-pad-xtest.x86_64: W: no-documentation
Revised spec file: http://github.com/fujiwarat/input-pad/commit/b5f1e4e738c0bb248d9fb59648ec06d87d58e250 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100608-1.fc13.src.rpm
Suggestions: 1) Please add more specific words of summary for this package. Like you can add "An on-screen input pad used to input symbols easily." 2) Before building in Fedora remove following un-necessary lines from SPEC Requires: glib2 >= %glib2_version Requires: gtk2 Requires: libX11 Requires: libxkbfile Requires: libxklavier >= %libxklavier_version Requires: libxml2 >= %libxml2_version 3) You can remove redundant BuildRequires BuildRequires: glib2-devel >= %glib2_version BuildRequires: libX11-devel as gtk2-devel will install them. However, I see gtk2-devel specifies glib2 version 2.23.6 and you specified 2.8 4) for have_python_devel, you should be using macros %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif 5) You should actually use following in %build to preserve upstream file's timestamps. Not mandatory by reviewguidelines but suggested a good fix by packaging guidelines. make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" 6) Make sure each change,if no new upstream version used then you bump the release and provide new SPEC and SRPM.
Revised spec file: http://github.com/fujiwarat/input-pad/commit/188f838f1ce0a8beb259c9df59dcd92b7e5a8eb4 Spec URL: http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec SRPM URL: http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100608-2.fc13.src.rpm (In reply to comment #8) > 1) Please add more specific words of summary for this package. Like you can add > "An on-screen input pad used to input symbols easily." I accept this in this time since other issues are also reported. > 2) Before building in Fedora remove following un-necessary lines from SPEC > Requires: glib2 >= %glib2_version > Requires: gtk2 > Requires: libX11 > Requires: libxkbfile > Requires: libxklavier >= %libxklavier_version > Requires: libxml2 >= %libxml2_version > I didn't notice Linux rpmbuild has the feature of auto-dependency. I accept this useful suggestion now. Thanks. > 5) You should actually use following in %build to preserve upstream file's > timestamps. Not mandatory by reviewguidelines but suggested a good fix by > packaging guidelines. > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Cool. -p is useful. > 6) Make sure each change,if no new upstream version used then you bump the > release and provide new SPEC and SRPM. OK, I will remember the Fedora policy.
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2242129 + rpmlint outputs input-pad.x86_64: W: incoherent-version-in-changelog 0.1.0.20100608-1 ['0.1.0.20100608-2.fc13', '0.1.0.20100608-2'] input-pad.x86_64: W: shared-lib-calls-exit /usr/lib64/libinput-pad.so.0.0.1 exit.5 input-pad.x86_64: W: no-manual-page-for-binary input-pad input-pad-devel.x86_64: W: no-documentation input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad.so _input_pad.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_window_gtk.so _input_pad_window_gtk.so()(64bit) input-pad-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/input-pad-0.1/_input_pad_group.so _input_pad_group.so()(64bit) input-pad-python.x86_64: W: no-documentation input-pad-xtest.x86_64: E: explicit-lib-dependency libXtst input-pad-xtest.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 9 warnings. + source files match upstream url (sha1sum) 11b4c1c69c5bf4a7d8abfe7172a72b75caab8c2a input-pad-0.1.0.20100608.tar.gz.srpm 11b4c1c69c5bf4a7d8abfe7172a72b75caab8c2a input-pad-0.1.0.20100608.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not required for F-13 and above builds. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + input-pad.pc file present. + -devel, -python, -xtest subpackage exists + no .la files. + translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package input-pad-0.1.0.20100608-2.fc13.x86_64 => Provides: libinput-pad.so.0()(64bit) Requires(interp): /sbin/ldconfig /sbin/ldconfig Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= Requires: libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) + PAckage input-pad-devel-0.1.0.20100608-2.fc13.x86_64=> Provides: pkgconfig(input-pad) = 0.1.0.20100608 Requires: /usr/bin/pkg-config libinput-pad.so.0()(64bit) pkgconfig(glib-2.0) pkgconfig(libxml-2.0) >= 2.0 + Package input-pad-python-0.1.0.20100608-2.fc13.x86_64 => Provides: _input_pad.so()(64bit) _input_pad_group.so()(64bit) _input_pad_window_gtk.so()(64bit) Requires: libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) libpython2.6.so.1.0()(64bit) librt.so.1()(64bit) libutil.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) python(abi) = 2.6 rtld(GNU_HASH) + Package input-pad-xtest-0.1.0.20100608-2.fc13.x86_64 => Provides: libinput-pad-xtest-gdk.so()(64bit) Requires: libX11.so.6()(64bit) libXtst.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libinput-pad.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libxkbfile.so.1()(64bit) libxklavier.so.16()(64bit) libxml2.so.2()(64bit) rtld(GNU_HASH) + Not a GUI application Suggestions: 1) Please add changelog entry for each release bump. You have wrong changelog entry with -1 as release whereas you have Release tag saying its -2 release. 2) you also don't need Requires: libXtst please remove it before you build in cvs.
New Package CVS Request ======================= Package Name: input-pad Short Description: On-screen Input Pad to Send Characters with Mouse Owners: fujiwara Branches: F-14, F-13, F-12 InitialCC: i18n-team
CVS done (by process-cvs-requests.py). We aren't doing F-14 branches yet.
Integrated in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=2248480
input-pad-0.1.0.20100614-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100614-1.fc13
input-pad-0.1.0.20100614-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100614-1.fc12
input-pad-0.1.0.20100614-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100614-1.fc12
input-pad-0.1.0.20100614-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100614-1.fc13
input-pad-0.1.0.20100622-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100622-1.fc13
input-pad-0.1.0.20100622-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100622-1.fc12
input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100630-1.fc13
input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update input-pad'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100630-1.fc12
input-pad-0.1.0.20100630-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
input-pad-0.1.0.20100630-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.