Spec URL: http://fedorapeople.org/~iarnell/review/perl-YAPE-Regex.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-YAPE-Regex-3.04-1.fc14.src.rpm Description: This module is yet another parser and tree-builder for Perl regular expressions. It builds a tree out of a regex, but at the moment, the extent of the extraction tool for the tree is quite limited. However, the tree can be useful to extension modules. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2227764 *rt-0.10_01
Throwing this back into the pool as Chris is busy with other things at the minute.
Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic (same as Perl) [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package match the upstream source, as provided in the spec URL. SHA1SUM of source file: [x] Package is not known to require ExcludeArch. [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. [x] Final provides and requires are sane. [wolfy@wolfy tmp]$ rpm -qp --provides perl-YAPE-Regex-3.04-1.el6.noarch.rpm perl(YAPE::Regex) = 3.04 perl(YAPE::Regex::alt) perl(YAPE::Regex::anchor) perl(YAPE::Regex::any) perl(YAPE::Regex::backref) perl(YAPE::Regex::capture) perl(YAPE::Regex::Cchar) perl(YAPE::Regex::class) perl(YAPE::Regex::close) perl(YAPE::Regex::code) perl(YAPE::Regex::comment) perl(YAPE::Regex::conditional) perl(YAPE::Regex::ctrl) perl(YAPE::Regex::cut) perl(YAPE::Regex::Element) = 3.00 perl(YAPE::Regex::flags) perl(YAPE::Regex::group) perl(YAPE::Regex::hex) perl(YAPE::Regex::later) perl(YAPE::Regex::lookahead) perl(YAPE::Regex::lookbehind) perl(YAPE::Regex::macro) perl(YAPE::Regex::named) perl(YAPE::Regex::oct) perl(YAPE::Regex::slash) perl(YAPE::Regex::text) perl(YAPE::Regex::whitespace) perl-YAPE-Regex = 3.04-1.el6 [wolfy@wolfy tmp]$ rpm -qp --requires perl-YAPE-Regex-3.04-1.el6.noarch.rpm perl(:MODULE_COMPAT_5.10.1) rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(VersionedDependencies) <= 3.0.3-1 perl(Carp) perl(strict) perl(Text::Balanced) perl(vars) perl(YAPE::Regex::Element) rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1 [wolfy@wolfy tmp]$ rpmlint perl-YAPE-Regex-3.04-1.* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. =>See note 1 below [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: EL-6beta2, koji scratch build [x] Package should compile and build into binary rpms on all supported architectures. Tested on: EL-6beta2, koji scratch build [x] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the test passes. === OPTIONAL ITEMS === [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). === Final Notes === 1. The actual license is missing from the tarball itself. A bug exists about that in CPAN. The packager has obtained the confirmation from the upstream author that the intended license is indeed the same as Parl has. ================ *** APPROVED *** ================
New Package CVS Request ======================= Package Name: perl-YAPE-Regex Short Description: Yet Another Parser/Extractor for Regular Expressions Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig
CVS done (by process-cvs-requests.py).
perl-YAPE-Regex-3.04-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-YAPE-Regex-3.04-1.fc13
perl-YAPE-Regex-3.04-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-YAPE-Regex-3.04-1.fc12
perl-YAPE-Regex-3.04-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-YAPE-Regex'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-YAPE-Regex-3.04-1.fc13
perl-YAPE-Regex-3.04-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-YAPE-Regex'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-YAPE-Regex-3.04-1.fc12
perl-YAPE-Regex-3.04-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
perl-YAPE-Regex-3.04-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.