Bug 600835 - Review Request: modplugtools - Command line mod music players
Summary: Review Request: modplugtools - Command line mod music players
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-06 09:28 UTC by Ville Skyttä
Modified: 2010-06-23 15:55 UTC (History)
3 users (show)

Fixed In Version: 0.5.0-2
Clone Of:
Environment:
Last Closed: 2010-06-23 15:55:03 UTC
Type: ---
Embargoed:
bugs.michael: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ville Skyttä 2010-06-06 09:28:57 UTC
http://scop.fedorapeople.org/packages/modplugtools.spec
http://scop.fedorapeople.org/packages/modplugtools-0.5.0-1.fc13.src.rpm
Description: Command line mod music players

Note that this package will obsolete the current modplugplay package in Fedora (a subpackage of xmms-modplug), I maintain it and will take care of it when this is in.  The self-obsoletion message from rpmlint for the binary package is an rpmlint bug, already fixed upstream post 0.97.

Comment 1 Michael Schwendt 2010-06-20 21:38:04 UTC
* The format string warnings during build are low-hanging fruit.  Plus, in modplug123.c, fixing the sprintf/printf leads to discovering that the value "order" is an uninitialized array/C-string.

* "modplug123 --help" refers to itself also as "modplugplay", which is a tiny bug.

* "License: GPL+" but files AUTHORS and COPYING refer to GPLv3 only.

Comment 2 Ville Skyttä 2010-06-21 16:39:21 UTC
http://scop.fedorapeople.org/packages/modplugtools-0.5.0-2.fc13.src.rpm

* Mon Jun 21 2010 Ville Skyttä <ville.skytta> - 0.5.0-2
- Patch to fix --help related issues (#600835).
- Patch to fix format string issues (#600835).
- License: GPLv3 (per the AUTHORS file) (#600835).

Comment 3 Michael Schwendt 2010-06-22 09:50:02 UTC
Good!

* Obsoletes/Provides with Epoch: verified
* Both players work for me with F-13 defaults.
* modplugtools-0.5.0-2.fc13.src.rpm

APPROVED

Comment 4 Ville Skyttä 2010-06-22 15:05:01 UTC
New Package CVS Request
=======================
Package Name: modplugtools
Short Description: Command line mod music players
Owners: scop
Branches: 
InitialCC:

Comment 5 Kevin Fenzi 2010-06-23 01:48:39 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.