Bug 601098 - virt-v2v | convert with wrong type didn't get any error or warning message
Summary: virt-v2v | convert with wrong type didn't get any error or warning message
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: virt-v2v   
(Show other bugs)
Version: 5.7
Hardware: All Linux
Target Milestone: rc
: ---
Assignee: Matthew Booth
QA Contact: Virtualization Bugs
Depends On:
TreeView+ depends on / blocked
Reported: 2010-06-07 08:27 UTC by Mohua Li
Modified: 2013-04-30 23:13 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-06-07 09:11:12 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

Description Mohua Li 2010-06-07 08:27:02 UTC
Description of problem:

convert the kvm image with xenpv/xenhvm configuration,get pass and without any message, better to check if the configuration in the guest image match with the configuration, if not, then give error message, but no just continue without any error, and it will make user confuse if convert with problem but without any warning or sth, although till now the wrong match could convert successfully,

virt-v2v -f /etc/virt-v2v.conf -i libvirtxml -o rhev -osd /tmp/RHEL-Server-5.4-32.raw.xml

[root@dhcp-66-70-148 v2v]# cat /tmp/RHEL-Server-5.4-32.raw.xml
<domain type='xen' id='307'>   //the configuration is for xen                      
    <boot dev='hd'/>
  <clock offset='utc'/>
    <disk type='file' device='disk'>
      <driver name='tap' type='aio'/>
      <source file='/media/disk/RHEL-Server-5.4-32.raw'/>      //kvm image
      <target dev='hda' bus='ide'/>
   <interface type='bridge'>
    <mac address='00:16:36:13:66:38'/>
      <source bridge='xenbr0'/>
      <script path='vif-bridge'/>
      <target dev='vif70.0'/>
    <serial type='pty'>
      <source path='/dev/pts/8'/>
      <target port='0'/>
    <console type='pty' tty='/dev/pts/8'>
      <source path='/dev/pts/8'/>
      <target port='0'/>
    <input type='mouse' bus='ps2'/>
    <graphics type='vnc' port='6207' autoport='yes'/>

here is a summary, what i tested,

base kernel,

1,kvm image with (xenpv configuration file, xenhvm configuration file), pass without error
2,xenpv image with kvm configuration file,                              pass without error, 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.convert with disk image and configuration didn't match like below,
virt-v2v -f /etc/virt-v2v.conf -i libvirtxml -o rhev -osd /tmp/RHEL-Server-5.4-32.raw.xml
2.check the convert result after finished,
Actual results:
convert completed without any error or warning 

Expected results:
should have error message, continue or not should depends on the detail implementation of the convert process, 

Additional info:
add the log during the convert process,

Comment 1 Matthew Booth 2010-06-07 09:11:12 UTC
We can't second guess things like this. The tool is already pretty resilient to this kind of error as it mostly looks at the disk image in isolation, which is why it worked. I don't think it's worth risking adding a whole new class of potential bugs by second guessing the data we were given.

Note You need to log in before you can comment on or make changes to this bug.