Bug 602291
| Summary: | netlabelctl returns 0 on error | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Miroslav Vadkerti <mvadkert> | ||||
| Component: | netlabel_tools | Assignee: | Peter Vrabec <pvrabec> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Miroslav Vadkerti <mvadkert> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 6.0 | CC: | sgrubb, syeghiay | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | netlabel_tools-0.19-6.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Previously, running the netlabelctl utility with an invalid mask argument caused the utility to terminate with a 0 exit status. This error has been fixed, and when an invalid mask is supplied, netlabelctl now returns a non-zero exit status as expected.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-02-02 15:26:07 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 584498, 846801, 846802 | ||||||
| Attachments: |
|
||||||
|
Description
Miroslav Vadkerti
2010-06-09 14:26:25 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Invalid mask is accepted: # netlabelctl map add domain:ping_t address:192.168.1.250/37 protocol:unlbl; echo $? 0 Addition to comment 2: # netlabelctl unlbl add interface:eth0 address:192.168.2.250/37 label:unconfined_u:object_r:admin_home_t:s0 # netlabelctl unlbl list accept:on interface:eth0,address:192.168.2.250/32,label:"unconfined_u:object_r:admin_home_t:s0" Should I open another bug for this issue? Attaching patch for this issue. Test below: [root@auto-s390-002 netlabelctl]# netlabelctl add default address:192.168.0.1 label:10; echo $? netlabelctl: error, unknown or missing module 'add' 1 Created attachment 424696 [details]
Proposed patch for fixing the unknown module wrong return value
thnx. Miro FAILS_QA in netlabel_tools-0.19-6.el6 1. FIXED # netlabelctl add default address:192.168.0.1 label:10; echo $? netlabelctl: error, unknown or missing module 'add' 1 2. STILL ACCEPTS bad mask # netlabelctl map add domain:ping_t address:192.168.1.250/37 protocol:unlbl;echo $? 0 This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative.
Technical note added. If any revisions are required, please edit the "Technical Notes" field
accordingly. All revisions will be proofread by the Engineering Content Services team.
New Contents:
Previously, running the netlabelctl utility with an invalid mask argument caused the utility to terminate with a 0 exit status. This error has been fixed, and when an invalid mask is supplied, netlabelctl now returns a non-zero exit status as expected.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0191.html |