Bug 602960 - Review Request: maven-eclipse-plugin - Maven Eclipse Plugin
Summary: Review Request: maven-eclipse-plugin - Maven Eclipse Plugin
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2010-06-11 06:42 UTC by Weinan Li
Modified: 2010-07-09 09:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-07-09 09:43:42 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
akurtako: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Weinan Li 2010-06-11 06:42:24 UTC
Spec URL: http://weli.fedorapeople.org/packages/fedora-14/maven-eclipse-plugin/maven-eclipse-plugin.spec
SRPM URL: http://weli.fedorapeople.org/packages/fedora-14/maven-eclipse-plugin/maven-eclipse-plugin-2.8-1.fc14.src.rpm

Description: The Eclipse Plugin is used to generate Eclipse IDE files (.project, .classpath and the .settings folder) from a POM.

Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a
successful koji scratch build:

Comment 1 Alexander Kurtakov 2010-06-12 13:20:09 UTC
I'll take this one.

Comment 2 Alexander Kurtakov 2010-06-14 09:20:08 UTC
OK: rpmlint must be run on every package. Output:
maven-eclipse-plugin.noarch: E: explicit-lib-dependency aqute-bndlib
This is not a lib package.

maven-eclipse-plugin.noarch: W: spelling-error %description -l en_US classpath -> class path, class-path, classmate
maven-eclipse-plugin.noarch: W: no-documentation
maven-eclipse-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-eclipse-plugin

False positives. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. There is no license file. 

Please ask upstream to include one.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8. 

It may be better to do 
# Install necessary package to maven repository
mvn-jpp \
        -e \
        -Dmaven2.jpp.mode=true \
        -Dmaven2.jpp.depmap.file=${MAVEN_DEPMAP} \
        -Dmaven.repo.local=$MAVEN_REPO_LOCAL \
        install:install-file \
        -DgroupId=org.eclipse.core \
        -DartifactId=resources \
        -Dversion=3.5.2-v201004121342 \
        -Dpackaging=jar \

in the %prep section.

Otherwise, package looks good.

This package is APPROVED.

Comment 3 Weinan Li 2010-06-16 11:27:05 UTC
New Package CVS Request
Package Name: maven-eclipse-plugin
Short Description: The Eclipse Plugin is used to generate Eclipse IDE files
(.project, .classpath and the .settings folder) from a POM.
Owners: weli
InitialCC: akurtakov

Comment 4 Kevin Fenzi 2010-06-21 02:17:30 UTC
CVS done (by process-cvs-requests.py).

Comment 5 Alexander Kurtakov 2010-06-30 11:37:45 UTC
Please close this bug if package is build in koji now.

Comment 6 Alexander Kurtakov 2010-07-09 09:43:42 UTC
Build in rawhide.

Note You need to log in before you can comment on or make changes to this bug.