Bug 603113 - import libvpx for WebM support
Summary: import libvpx for WebM support
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: distribution
Version: 6.0
Hardware: All
OS: Linux
Target Milestone: rc
: ---
Assignee: RHEL Product and Program Management
QA Contact: Ben Levenson
Keywords: FutureFeature
Depends On: 605271
Blocks: 603100 603110
TreeView+ depends on / blocked
Reported: 2010-06-11 14:54 UTC by Benjamin Otte
Modified: 2010-11-10 20:16 UTC (History)
8 users (show)

Clone Of:
Last Closed: 2010-11-10 20:16:56 UTC

Attachments (Terms of Use)
gas libvpx-0.9.0-6.fc14 (=F-13) - with removed BuildRequires: yasm (1.05 MB, patch)
2010-06-20 21:06 UTC, Jan Kratochvil
no flags Details | Diff
Comparison patch. (2.88 KB, patch)
2010-06-20 21:08 UTC, Jan Kratochvil
no flags Details | Diff

Description Benjamin Otte 2010-06-11 14:54:25 UTC
To add support for WebM, GStreamer needs libvpx packages imported from Fedora.

Comment 4 Jan Kratochvil 2010-06-20 21:06:06 UTC
Created attachment 425485 [details]
gas libvpx-0.9.0-6.fc14 (=F-13) - with removed BuildRequires: yasm

Comment 5 Jan Kratochvil 2010-06-20 21:08:43 UTC
Created attachment 425486 [details]
Comparison patch.

libvpx-0.9.0-6.fc14 adjusted to binary-match (tested only asm .o files) for verification of the gas variant.  This patch still builds libvpx by yasm.

        pinsrw      mm0,    rcx,  0
- 20b:  48 0f c4 c1 00          pinsrw $0x0,%rcx,%mm0
+ 20b:  0f c4 c1 00             pinsrw $0x0,%ecx,%mm0

        mov             rax,  vp8_sad16x16x3_ssse3_jumptable - vp8_sad16x16x3_ssse3_do_jump
-      67:      48 b8 bb ff ff ff ff    movabs $0xffffffffffffffbb,%rax
-      6e:      ff ff ff
+      67:      48 c7 c0 bb ff ff ff    mov    $0xffffffffffffffbb,%rax
        mov             rax,  vp8_sad16x8x3_ssse3_jumptable - vp8_sad16x8x3_ssse3_do_jump

for i in `find -name "*.S"`;do strip -x $i.o;objdump -dr $i.o >2;objdump -dr ../libvpx-0.9.0-bc/`echo $i|sed 's/\.S$/.asm/'`.o >1;echo $i;diff -u 1 2;done|vi -

Comment 7 Jan Kratochvil 2010-06-21 21:00:55 UTC
BTW upstream has 0.9.1 (+newer GIT); Fedora Rawhide still contains 0.9.0.

One should check the upstream patches:
 * There is a stack non-executability implementation - it may affect SELinux.
 * There are various backend fixes which may not be immediately visible
   as the developer's machine chooses a different backend.

QA: All the supported optimized backends (MMX/SSE2/SSSE3/etc.) should be probably tested.

Post upstream (had to use Midori/webkit, it is Firefox/Gecko-incompatible):

Comment 8 Benjamin Otte 2010-06-30 15:59:32 UTC
The package was imported into CVS and successfully built.

Comment 12 releng-rhel@redhat.com 2010-11-10 20:16:56 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.

Note You need to log in before you can comment on or make changes to this bug.