Spec URL: http://jgu.fedorapeople.org/coan.spec SRPM URL: http://jgu.fedorapeople.org/coan-4.1-1.fc13.src.rpm Description: Coan is a software engineering tool for analysing preprocessor-based configurations of C or C++ source code. Its principal use is to simplify a body of source code by eliminating any parts that are redundant with respect to a specified configuration. NOTE: this package was formerly called sunifdef, and upstream has renamed the project to coan. This is a package re-review request in order to comply with the FESCO procedure for renaming a package as specified here: http://fedoraproject.org/wiki/Package_Renaming_Process#Re-review_required
Review: Good: - name ok - Provides/Obsoletes of the old package ok - %build ok - %check there - no libs - no .la - license ok Needswork: - %files: please use %{_mandir}/man1/%{name}.1.*, so the man pages compression can change at will. - second paragraph in description is still "Sunifdef". Needs to be %{name} - please use INSTALL="install -p" when installing - the first few lines would be more readable, when name, version etc would be properly aligned... - removing of the excecutable bit on *.c and *.h and the for loop in %prep are not needed anymore - rpmlint: $ rpmlint ./coan-4.1-1.fc13.src.rpm ./x86_64/coan-* coan.src: W: spelling-error Summary(en_US) preprocessor -> processor, teleprocessing, processional coan.src: W: spelling-error %description -l en_US sunifdef -> sundries, sunshade, Sunnite coan.src: W: spelling-error %description -l en_US analysing -> analyzing, analysis, analysand coan.src: W: spelling-error %description -l en_US preprocessor -> processor, teleprocessing, processional coan.src: W: spelling-error %description -l en_US Sunifdef -> Sundries, Sunshade, Sunnite coan.src: W: spelling-error %description -l en_US ifdef -> if def, if-def, infidel coan.src: W: no-cleaning-of-buildroot %install coan.src: W: no-cleaning-of-buildroot %clean coan.src: W: no-buildroot-tag coan.src: W: no-%clean-section coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> processor, teleprocessing, processional coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries, sunshade, Sunnite coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing, analysis, analysand coan.x86_64: W: spelling-error %description -l en_US preprocessor -> processor, teleprocessing, processional coan.x86_64: W: spelling-error %description -l en_US Sunifdef -> Sundries, Sunshade, Sunnite coan.x86_64: W: spelling-error %description -l en_US ifdef -> if def, if-def, infidel 3 packages and 0 specfiles checked; 0 errors, 16 warnings. ** analysing -> analyzing is a spelling error, the rest is ignorable on a recent fedora version. ############################################################################### The man pages compression and description change is a MUST, the other SHOULDS. Approving, when the first two have changed (I bet you will ;)). ############################################################################### APPROVED
Thanks very much Thomas, comments below. New spec and srpm: Spec URL: http://jgu.fedorapeople.org/coan.spec SRPM URL: http://jgu.fedorapeople.org/coan-4.1-2.fc13.src.rpm (In reply to comment #1) > Needswork: > - %files: please use %{_mandir}/man1/%{name}.1.*, so the man pages compression > can change at will. Done. > - second paragraph in description is still "Sunifdef". Needs to be %{name} > Fixed. > - please use INSTALL="install -p" when installing Done. > - the first few lines would be more readable, when name, version etc would be > properly aligned... Done. > - removing of the excecutable bit on *.c and *.h and the for loop in %prep are > not needed anymore OK, removed. > - rpmlint: > $ rpmlint ./coan-4.1-1.fc13.src.rpm ./x86_64/coan-* > coan.src: W: spelling-error Summary(en_US) preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.src: W: spelling-error %description -l en_US sunifdef -> sundries, > sunshade, Sunnite Ignored. > coan.src: W: spelling-error %description -l en_US analysing -> analyzing, > analysis, analysand Fixed (heh, both me and the upstream author are from the UK, and that was a copy and paste from the web page). > coan.src: W: spelling-error %description -l en_US preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.src: W: spelling-error %description -l en_US Sunifdef -> Sundries, > Sunshade, Sunnite Replaced with %{name} > coan.src: W: spelling-error %description -l en_US ifdef -> if def, if-def, > infidel Ignored. > coan.src: W: no-cleaning-of-buildroot %install > coan.src: W: no-cleaning-of-buildroot %clean > coan.src: W: no-buildroot-tag > coan.src: W: no-%clean-section These are no longer needed -> ignored. > coan.x86_64: W: spelling-error Summary(en_US) preprocessor -> processor, > teleprocessing, processional Changed to pre-processor > coan.x86_64: W: spelling-error %description -l en_US sunifdef -> sundries, > sunshade, Sunnite Replaced with %{name} > coan.x86_64: W: spelling-error %description -l en_US analysing -> analyzing, > analysis, analysand Fixed. > coan.x86_64: W: spelling-error %description -l en_US preprocessor -> processor, > teleprocessing, processional Replaced with pre-processor > coan.x86_64: W: spelling-error %description -l en_US Sunifdef -> Sundries, > Sunshade, Sunnite Replaced with %{name} > coan.x86_64: W: spelling-error %description -l en_US ifdef -> if def, if-def, > infidel Ignored. > 3 packages and 0 specfiles checked; 0 errors, 16 warnings. > > ** analysing -> analyzing is a spelling error, the rest is ignorable on a > recent fedora version. > > > ############################################################################### > > The man pages compression and description change is a MUST, the other SHOULDS. > Approving, when the first two have changed (I bet you will ;)). Yup, done. > > ############################################################################### > > APPROVED Cheers.
New Package CVS Request ======================= Package Name: coan Short Description: A command line tool for simplifying the pre-processor conditionals in source code Owners: jgu Branches: F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Thanks Kevin. coan packages built for devel and F-13 branches, closing bz.
Package Change Request ====================== Package Name: coan New Branches: el6 Owners: jgu InitialCC:
Git done (by process-git-requests).